content/browser/manifest/manifest_browsertest.cc - Issue 1545243002: Convert Pass()→std::move() in //content/browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/manifest/manifest_browsertest.cc

Issue 1545243002: Convert Pass()→std::move() in //content/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/throttling_resource_handler.cc ('k') | content/browser/media/capture/aura_window_capture_machine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/manifest/manifest_browsertest.cc

diff --git a/content/browser/manifest/manifest_browsertest.cc b/content/browser/manifest/manifest_browsertest.cc

index f340f1756c13abd2effd9cc44fcb8266bb613289..8dab4696ecda6a90e8239b3ea2ff0d18280a7c8f 100644

--- a/content/browser/manifest/manifest_browsertest.cc

+++ b/content/browser/manifest/manifest_browsertest.cc

@@ -3,6 +3,7 @@

// found in the LICENSE file.

#include <stdint.h>

+#include <utility>

#include "base/command_line.h"

#include "base/macros.h"

@@ -497,7 +498,7 @@ scoped_ptr<net::test_server::HttpResponse> CustomHandleRequestForCookies(

"<html><head>"

"<link rel=manifest crossorigin='use-credentials' href=/manifest.json>"

"</head></html>");

- return http_response.Pass();

+ return std::move(http_response);

}

const auto& iter = request.headers.find("Cookie");

@@ -511,7 +512,7 @@ scoped_ptr<net::test_server::HttpResponse> CustomHandleRequestForCookies(

http_response->set_content(

base::StringPrintf("{\"name\": \"%s\"}", iter->second.c_str()));

- return http_response.Pass();

+ return std::move(http_response);

}

} // anonymous namespace

@@ -557,7 +558,7 @@ scoped_ptr<net::test_server::HttpResponse> CustomHandleRequestForNoCookies(

http_response->set_content_type("text/html");

http_response->set_content(

"<html><head><link rel=manifest href=/manifest.json></head></html>");

- return http_response.Pass();

+ return std::move(http_response);

}

const auto& iter = request.headers.find("Cookie");

@@ -570,7 +571,7 @@ scoped_ptr<net::test_server::HttpResponse> CustomHandleRequestForNoCookies(

http_response->set_content_type("application/json");

http_response->set_content("{\"name\": \"no cookies\"}");

- return http_response.Pass();

+ return std::move(http_response);

}

} // anonymous namespace