Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 1545243002: Convert Pass()→std::move() in //content/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
index 218579cef3e8a9e1b1ffaa66cb2abe03705bce33..bc950704e93f96a6ccaf3b12984bc7311efd0e57 100644
--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
@@ -3,6 +3,7 @@
// found in the LICENSE file.
#include <stddef.h>
+#include <utility>
#include "base/base64.h"
#include "base/command_line.h"
@@ -47,7 +48,7 @@ class DevToolsProtocolTest : public ContentBrowserTest,
protected:
void SendCommand(const std::string& method,
scoped_ptr<base::DictionaryValue> params) {
- SendCommand(method, params.Pass(), true);
+ SendCommand(method, std::move(params), true);
}
void SendCommand(const std::string& method,
@@ -167,7 +168,7 @@ class SyntheticKeyEventTest : public DevToolsProtocolTest {
params->SetInteger("modifiers", modifier);
params->SetInteger("windowsVirtualKeyCode", windowsKeyCode);
params->SetInteger("nativeVirtualKeyCode", nativeKeyCode);
- SendCommand("Input.dispatchKeyEvent", params.Pass());
+ SendCommand("Input.dispatchKeyEvent", std::move(params));
}
};
@@ -343,7 +344,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, NavigationPreservesMessages) {
scoped_ptr<base::DictionaryValue> params(new base::DictionaryValue());
test_url = GetTestUrl("devtools", "navigation.html");
params->SetString("url", test_url.spec());
- SendCommand("Page.navigate", params.Pass(), true);
+ SendCommand("Page.navigate", std::move(params), true);
bool enough_results = result_ids_.size() >= 2u;
EXPECT_TRUE(enough_results);
« no previous file with comments | « content/browser/devtools/devtools_protocol_handler.cc ('k') | content/browser/devtools/protocol/emulation_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698