Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: content/browser/renderer_host/websocket_host.cc

Issue 1545243002: Convert Pass()→std::move() in //content/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/websocket_host.h" 5 #include "content/browser/renderer_host/websocket_host.h"
6 6
7 #include <utility>
8
7 #include "base/location.h" 9 #include "base/location.h"
8 #include "base/macros.h" 10 #include "base/macros.h"
9 #include "base/memory/weak_ptr.h" 11 #include "base/memory/weak_ptr.h"
10 #include "base/single_thread_task_runner.h" 12 #include "base/single_thread_task_runner.h"
11 #include "base/strings/string_util.h" 13 #include "base/strings/string_util.h"
12 #include "base/thread_task_runner_handle.h" 14 #include "base/thread_task_runner_handle.h"
13 #include "content/browser/renderer_host/websocket_dispatcher_host.h" 15 #include "content/browser/renderer_host/websocket_dispatcher_host.h"
14 #include "content/browser/ssl/ssl_error_handler.h" 16 #include "content/browser/ssl/ssl_error_handler.h"
15 #include "content/browser/ssl/ssl_manager.h" 17 #include "content/browser/ssl/ssl_manager.h"
16 #include "content/common/websocket_messages.h" 18 #include "content/common/websocket_messages.h"
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 269
268 ChannelState WebSocketEventHandler::OnSSLCertificateError( 270 ChannelState WebSocketEventHandler::OnSSLCertificateError(
269 scoped_ptr<net::WebSocketEventInterface::SSLErrorCallbacks> callbacks, 271 scoped_ptr<net::WebSocketEventInterface::SSLErrorCallbacks> callbacks,
270 const GURL& url, 272 const GURL& url,
271 const net::SSLInfo& ssl_info, 273 const net::SSLInfo& ssl_info,
272 bool fatal) { 274 bool fatal) {
273 DVLOG(3) << "WebSocketEventHandler::OnSSLCertificateError" 275 DVLOG(3) << "WebSocketEventHandler::OnSSLCertificateError"
274 << " routing_id=" << routing_id_ << " url=" << url.spec() 276 << " routing_id=" << routing_id_ << " url=" << url.spec()
275 << " cert_status=" << ssl_info.cert_status << " fatal=" << fatal; 277 << " cert_status=" << ssl_info.cert_status << " fatal=" << fatal;
276 ssl_error_handler_delegate_.reset( 278 ssl_error_handler_delegate_.reset(
277 new SSLErrorHandlerDelegate(callbacks.Pass())); 279 new SSLErrorHandlerDelegate(std::move(callbacks)));
278 SSLManager::OnSSLCertificateSubresourceError( 280 SSLManager::OnSSLCertificateSubresourceError(
279 ssl_error_handler_delegate_->GetWeakPtr(), url, 281 ssl_error_handler_delegate_->GetWeakPtr(), url,
280 dispatcher_->render_process_id(), render_frame_id_, ssl_info, fatal); 282 dispatcher_->render_process_id(), render_frame_id_, ssl_info, fatal);
281 // The above method is always asynchronous. 283 // The above method is always asynchronous.
282 return WebSocketEventInterface::CHANNEL_ALIVE; 284 return WebSocketEventInterface::CHANNEL_ALIVE;
283 } 285 }
284 286
285 WebSocketEventHandler::SSLErrorHandlerDelegate::SSLErrorHandlerDelegate( 287 WebSocketEventHandler::SSLErrorHandlerDelegate::SSLErrorHandlerDelegate(
286 scoped_ptr<net::WebSocketEventInterface::SSLErrorCallbacks> callbacks) 288 scoped_ptr<net::WebSocketEventInterface::SSLErrorCallbacks> callbacks)
287 : callbacks_(callbacks.Pass()), weak_ptr_factory_(this) {} 289 : callbacks_(std::move(callbacks)), weak_ptr_factory_(this) {}
288 290
289 WebSocketEventHandler::SSLErrorHandlerDelegate::~SSLErrorHandlerDelegate() {} 291 WebSocketEventHandler::SSLErrorHandlerDelegate::~SSLErrorHandlerDelegate() {}
290 292
291 base::WeakPtr<SSLErrorHandler::Delegate> 293 base::WeakPtr<SSLErrorHandler::Delegate>
292 WebSocketEventHandler::SSLErrorHandlerDelegate::GetWeakPtr() { 294 WebSocketEventHandler::SSLErrorHandlerDelegate::GetWeakPtr() {
293 return weak_ptr_factory_.GetWeakPtr(); 295 return weak_ptr_factory_.GetWeakPtr();
294 } 296 }
295 297
296 void WebSocketEventHandler::SSLErrorHandlerDelegate::CancelSSLRequest( 298 void WebSocketEventHandler::SSLErrorHandlerDelegate::CancelSSLRequest(
297 int error, 299 int error,
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 DVLOG(3) << "WebSocketHost::AddChannel" 377 DVLOG(3) << "WebSocketHost::AddChannel"
376 << " routing_id=" << routing_id_ << " socket_url=\"" << socket_url 378 << " routing_id=" << routing_id_ << " socket_url=\"" << socket_url
377 << "\" requested_protocols=\"" 379 << "\" requested_protocols=\""
378 << base::JoinString(requested_protocols, ", ") << "\" origin=\"" 380 << base::JoinString(requested_protocols, ", ") << "\" origin=\""
379 << origin << "\""; 381 << origin << "\"";
380 382
381 DCHECK(!channel_); 383 DCHECK(!channel_);
382 384
383 scoped_ptr<net::WebSocketEventInterface> event_interface( 385 scoped_ptr<net::WebSocketEventInterface> event_interface(
384 new WebSocketEventHandler(dispatcher_, routing_id_, render_frame_id)); 386 new WebSocketEventHandler(dispatcher_, routing_id_, render_frame_id));
385 channel_.reset( 387 channel_.reset(new net::WebSocketChannel(std::move(event_interface),
386 new net::WebSocketChannel(event_interface.Pass(), url_request_context_)); 388 url_request_context_));
387 389
388 if (pending_flow_control_quota_ > 0) { 390 if (pending_flow_control_quota_ > 0) {
389 // channel_->SendFlowControl(pending_flow_control_quota_) must be called 391 // channel_->SendFlowControl(pending_flow_control_quota_) must be called
390 // after channel_->SendAddChannelRequest() below. 392 // after channel_->SendAddChannelRequest() below.
391 // We post OnFlowControl() here using |weak_ptr_factory_| instead of 393 // We post OnFlowControl() here using |weak_ptr_factory_| instead of
392 // calling SendFlowControl directly, because |this| may have been deleted 394 // calling SendFlowControl directly, because |this| may have been deleted
393 // after channel_->SendAddChannelRequest(). 395 // after channel_->SendAddChannelRequest().
394 base::ThreadTaskRunnerHandle::Get()->PostTask( 396 base::ThreadTaskRunnerHandle::Get()->PostTask(
395 FROM_HERE, base::Bind(&WebSocketHost::OnFlowControl, 397 FROM_HERE, base::Bind(&WebSocketHost::OnFlowControl,
396 weak_ptr_factory_.GetWeakPtr(), 398 weak_ptr_factory_.GetWeakPtr(),
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 ""); 447 "");
446 DCHECK_EQ(WebSocketDispatcherHost::WEBSOCKET_HOST_DELETED, result); 448 DCHECK_EQ(WebSocketDispatcherHost::WEBSOCKET_HOST_DELETED, result);
447 return; 449 return;
448 } 450 }
449 451
450 // TODO(yhirano): Handle |was_clean| appropriately. 452 // TODO(yhirano): Handle |was_clean| appropriately.
451 channel_->StartClosingHandshake(code, reason); 453 channel_->StartClosingHandshake(code, reason);
452 } 454 }
453 455
454 } // namespace content 456 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698