Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Side by Side Diff: net/url_request/certificate_report_sender.cc

Issue 1545233002: Convert Pass()→std::move() in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/udp/udp_net_log_parameters.cc ('k') | net/url_request/sdch_dictionary_fetcher_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/certificate_report_sender.h" 5 #include "net/url_request/certificate_report_sender.h"
6 6
7 #include <utility>
8
7 #include "base/stl_util.h" 9 #include "base/stl_util.h"
8 #include "net/base/elements_upload_data_stream.h" 10 #include "net/base/elements_upload_data_stream.h"
9 #include "net/base/load_flags.h" 11 #include "net/base/load_flags.h"
10 #include "net/base/request_priority.h" 12 #include "net/base/request_priority.h"
11 #include "net/base/upload_bytes_element_reader.h" 13 #include "net/base/upload_bytes_element_reader.h"
12 #include "net/url_request/url_request_context.h" 14 #include "net/url_request/url_request_context.h"
13 #include "net/url_request/url_request_status.h" 15 #include "net/url_request/url_request_status.h"
14 16
15 namespace net { 17 namespace net {
16 18
(...skipping 18 matching lines...) Expand all
35 if (cookies_preference_ != SEND_COOKIES) { 37 if (cookies_preference_ != SEND_COOKIES) {
36 load_flags |= LOAD_DO_NOT_SEND_COOKIES | LOAD_DO_NOT_SAVE_COOKIES; 38 load_flags |= LOAD_DO_NOT_SEND_COOKIES | LOAD_DO_NOT_SAVE_COOKIES;
37 } 39 }
38 url_request->SetLoadFlags(load_flags); 40 url_request->SetLoadFlags(load_flags);
39 41
40 url_request->set_method("POST"); 42 url_request->set_method("POST");
41 43
42 scoped_ptr<UploadElementReader> reader( 44 scoped_ptr<UploadElementReader> reader(
43 UploadOwnedBytesElementReader::CreateWithString(report)); 45 UploadOwnedBytesElementReader::CreateWithString(report));
44 url_request->set_upload( 46 url_request->set_upload(
45 ElementsUploadDataStream::CreateWithReader(reader.Pass(), 0)); 47 ElementsUploadDataStream::CreateWithReader(std::move(reader), 0));
46 48
47 URLRequest* raw_url_request = url_request.get(); 49 URLRequest* raw_url_request = url_request.get();
48 inflight_requests_.insert(url_request.release()); 50 inflight_requests_.insert(url_request.release());
49 raw_url_request->Start(); 51 raw_url_request->Start();
50 } 52 }
51 53
52 void CertificateReportSender::OnResponseStarted(URLRequest* request) { 54 void CertificateReportSender::OnResponseStarted(URLRequest* request) {
53 // TODO(estark): call a callback so that the caller can print a 55 // TODO(estark): call a callback so that the caller can print a
54 // warning on failure. 56 // warning on failure.
55 DVLOG(1) << "Failed to send certificate report for " << request->url().host(); 57 DVLOG(1) << "Failed to send certificate report for " << request->url().host();
56 58
57 CHECK_GT(inflight_requests_.erase(request), 0u); 59 CHECK_GT(inflight_requests_.erase(request), 0u);
58 // Clean up the request, which cancels it. 60 // Clean up the request, which cancels it.
59 delete request; 61 delete request;
60 } 62 }
61 63
62 void CertificateReportSender::OnReadCompleted(URLRequest* request, 64 void CertificateReportSender::OnReadCompleted(URLRequest* request,
63 int bytes_read) { 65 int bytes_read) {
64 NOTREACHED(); 66 NOTREACHED();
65 } 67 }
66 68
67 } // namespace net 69 } // namespace net
OLDNEW
« no previous file with comments | « net/udp/udp_net_log_parameters.cc ('k') | net/url_request/sdch_dictionary_fetcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698