Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: net/spdy/spdy_buffer.cc

Issue 1545233002: Convert Pass()→std::move() in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/socket/websocket_transport_connect_sub_job.h ('k') | net/spdy/spdy_buffer_producer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_buffer.h" 5 #include "net/spdy/spdy_buffer.h"
6 6
7 #include <cstring> 7 #include <cstring>
8 #include <utility>
8 9
9 #include "base/callback.h" 10 #include "base/callback.h"
10 #include "base/logging.h" 11 #include "base/logging.h"
11 #include "base/macros.h" 12 #include "base/macros.h"
12 #include "net/base/io_buffer.h" 13 #include "net/base/io_buffer.h"
13 #include "net/spdy/spdy_protocol.h" 14 #include "net/spdy/spdy_protocol.h"
14 15
15 namespace net { 16 namespace net {
16 17
17 namespace { 18 namespace {
18 19
19 // Bound on largest frame any SPDY version has allowed. 20 // Bound on largest frame any SPDY version has allowed.
20 const size_t kMaxSpdyFrameSize = 0x00ffffff; 21 const size_t kMaxSpdyFrameSize = 0x00ffffff;
21 22
22 // Makes a SpdyFrame with |size| bytes of data copied from 23 // Makes a SpdyFrame with |size| bytes of data copied from
23 // |data|. |data| must be non-NULL and |size| must be positive. 24 // |data|. |data| must be non-NULL and |size| must be positive.
24 scoped_ptr<SpdyFrame> MakeSpdyFrame(const char* data, size_t size) { 25 scoped_ptr<SpdyFrame> MakeSpdyFrame(const char* data, size_t size) {
25 DCHECK(data); 26 DCHECK(data);
26 CHECK_GT(size, 0u); 27 CHECK_GT(size, 0u);
27 CHECK_LE(size, kMaxSpdyFrameSize); 28 CHECK_LE(size, kMaxSpdyFrameSize);
28 scoped_ptr<char[]> frame_data(new char[size]); 29 scoped_ptr<char[]> frame_data(new char[size]);
29 std::memcpy(frame_data.get(), data, size); 30 std::memcpy(frame_data.get(), data, size);
30 scoped_ptr<SpdyFrame> frame( 31 scoped_ptr<SpdyFrame> frame(
31 new SpdyFrame(frame_data.release(), size, true /* owns_buffer */)); 32 new SpdyFrame(frame_data.release(), size, true /* owns_buffer */));
32 return frame.Pass(); 33 return frame;
33 } 34 }
34 35
35 } // namespace 36 } // namespace
36 37
37 // This class is an IOBuffer implementation that simply holds a 38 // This class is an IOBuffer implementation that simply holds a
38 // reference to a SharedFrame object and a fixed offset. Used by 39 // reference to a SharedFrame object and a fixed offset. Used by
39 // SpdyBuffer::GetIOBufferForRemainingData(). 40 // SpdyBuffer::GetIOBufferForRemainingData().
40 class SpdyBuffer::SharedFrameIOBuffer : public IOBuffer { 41 class SpdyBuffer::SharedFrameIOBuffer : public IOBuffer {
41 public: 42 public:
42 SharedFrameIOBuffer(const scoped_refptr<SharedFrame>& shared_frame, 43 SharedFrameIOBuffer(const scoped_refptr<SharedFrame>& shared_frame,
43 size_t offset) 44 size_t offset)
44 : IOBuffer(shared_frame->data->data() + offset), 45 : IOBuffer(shared_frame->data->data() + offset),
45 shared_frame_(shared_frame) {} 46 shared_frame_(shared_frame) {}
46 47
47 private: 48 private:
48 ~SharedFrameIOBuffer() override { 49 ~SharedFrameIOBuffer() override {
49 // Prevent ~IOBuffer() from trying to delete |data_|. 50 // Prevent ~IOBuffer() from trying to delete |data_|.
50 data_ = NULL; 51 data_ = NULL;
51 } 52 }
52 53
53 const scoped_refptr<SharedFrame> shared_frame_; 54 const scoped_refptr<SharedFrame> shared_frame_;
54 55
55 DISALLOW_COPY_AND_ASSIGN(SharedFrameIOBuffer); 56 DISALLOW_COPY_AND_ASSIGN(SharedFrameIOBuffer);
56 }; 57 };
57 58
58 SpdyBuffer::SpdyBuffer(scoped_ptr<SpdyFrame> frame) 59 SpdyBuffer::SpdyBuffer(scoped_ptr<SpdyFrame> frame)
59 : shared_frame_(new SharedFrame()), 60 : shared_frame_(new SharedFrame()),
60 offset_(0) { 61 offset_(0) {
61 shared_frame_->data = frame.Pass(); 62 shared_frame_->data = std::move(frame);
62 } 63 }
63 64
64 // The given data may not be strictly a SPDY frame; we (ab)use 65 // The given data may not be strictly a SPDY frame; we (ab)use
65 // |frame_| just as a container. 66 // |frame_| just as a container.
66 SpdyBuffer::SpdyBuffer(const char* data, size_t size) : 67 SpdyBuffer::SpdyBuffer(const char* data, size_t size) :
67 shared_frame_(new SharedFrame()), 68 shared_frame_(new SharedFrame()),
68 offset_(0) { 69 offset_(0) {
69 CHECK_GT(size, 0u); 70 CHECK_GT(size, 0u);
70 CHECK_LE(size, kMaxSpdyFrameSize); 71 CHECK_LE(size, kMaxSpdyFrameSize);
71 shared_frame_->data = MakeSpdyFrame(data, size); 72 shared_frame_->data = MakeSpdyFrame(data, size);
(...skipping 29 matching lines...) Expand all
101 DCHECK_GE(consume_size, 1u); 102 DCHECK_GE(consume_size, 1u);
102 DCHECK_LE(consume_size, GetRemainingSize()); 103 DCHECK_LE(consume_size, GetRemainingSize());
103 offset_ += consume_size; 104 offset_ += consume_size;
104 for (std::vector<ConsumeCallback>::const_iterator it = 105 for (std::vector<ConsumeCallback>::const_iterator it =
105 consume_callbacks_.begin(); it != consume_callbacks_.end(); ++it) { 106 consume_callbacks_.begin(); it != consume_callbacks_.end(); ++it) {
106 it->Run(consume_size, consume_source); 107 it->Run(consume_size, consume_source);
107 } 108 }
108 }; 109 };
109 110
110 } // namespace net 111 } // namespace net
OLDNEW
« no previous file with comments | « net/socket/websocket_transport_connect_sub_job.h ('k') | net/spdy/spdy_buffer_producer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698