Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: net/log/trace_net_log_observer.cc

Issue 1545233002: Convert Pass()→std::move() in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/log/test_net_log_entry.cc ('k') | net/log/trace_net_log_observer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/log/trace_net_log_observer.h" 5 #include "net/log/trace_net_log_observer.h"
6 6
7 #include <stdio.h> 7 #include <stdio.h>
8
9 #include <string> 8 #include <string>
9 #include <utility>
10 10
11 #include "base/json/json_writer.h" 11 #include "base/json/json_writer.h"
12 #include "base/logging.h" 12 #include "base/logging.h"
13 #include "base/memory/scoped_ptr.h" 13 #include "base/memory/scoped_ptr.h"
14 #include "base/trace_event/trace_event.h" 14 #include "base/trace_event/trace_event.h"
15 #include "base/values.h" 15 #include "base/values.h"
16 #include "net/log/net_log.h" 16 #include "net/log/net_log.h"
17 17
18 namespace net { 18 namespace net {
19 19
20 namespace { 20 namespace {
21 21
22 // TraceLog category for NetLog events. 22 // TraceLog category for NetLog events.
23 const char kNetLogTracingCategory[] = "netlog"; 23 const char kNetLogTracingCategory[] = "netlog";
24 24
25 class TracedValue : public base::trace_event::ConvertableToTraceFormat { 25 class TracedValue : public base::trace_event::ConvertableToTraceFormat {
26 public: 26 public:
27 explicit TracedValue(scoped_ptr<base::Value> value) : value_(value.Pass()) {} 27 explicit TracedValue(scoped_ptr<base::Value> value)
28 : value_(std::move(value)) {}
28 29
29 private: 30 private:
30 ~TracedValue() override {} 31 ~TracedValue() override {}
31 32
32 void AppendAsTraceFormat(std::string* out) const override { 33 void AppendAsTraceFormat(std::string* out) const override {
33 if (value_) { 34 if (value_) {
34 std::string tmp; 35 std::string tmp;
35 base::JSONWriter::Write(*value_, &tmp); 36 base::JSONWriter::Write(*value_, &tmp);
36 *out += tmp; 37 *out += tmp;
37 } else { 38 } else {
(...skipping 17 matching lines...) Expand all
55 56
56 void TraceNetLogObserver::OnAddEntry(const NetLog::Entry& entry) { 57 void TraceNetLogObserver::OnAddEntry(const NetLog::Entry& entry) {
57 scoped_ptr<base::Value> params(entry.ParametersToValue()); 58 scoped_ptr<base::Value> params(entry.ParametersToValue());
58 switch (entry.phase()) { 59 switch (entry.phase()) {
59 case NetLog::PHASE_BEGIN: 60 case NetLog::PHASE_BEGIN:
60 TRACE_EVENT_NESTABLE_ASYNC_BEGIN2( 61 TRACE_EVENT_NESTABLE_ASYNC_BEGIN2(
61 kNetLogTracingCategory, NetLog::EventTypeToString(entry.type()), 62 kNetLogTracingCategory, NetLog::EventTypeToString(entry.type()),
62 entry.source().id, "source_type", 63 entry.source().id, "source_type",
63 NetLog::SourceTypeToString(entry.source().type), "params", 64 NetLog::SourceTypeToString(entry.source().type), "params",
64 scoped_refptr<base::trace_event::ConvertableToTraceFormat>( 65 scoped_refptr<base::trace_event::ConvertableToTraceFormat>(
65 new TracedValue(params.Pass()))); 66 new TracedValue(std::move(params))));
66 break; 67 break;
67 case NetLog::PHASE_END: 68 case NetLog::PHASE_END:
68 TRACE_EVENT_NESTABLE_ASYNC_END2( 69 TRACE_EVENT_NESTABLE_ASYNC_END2(
69 kNetLogTracingCategory, NetLog::EventTypeToString(entry.type()), 70 kNetLogTracingCategory, NetLog::EventTypeToString(entry.type()),
70 entry.source().id, "source_type", 71 entry.source().id, "source_type",
71 NetLog::SourceTypeToString(entry.source().type), "params", 72 NetLog::SourceTypeToString(entry.source().type), "params",
72 scoped_refptr<base::trace_event::ConvertableToTraceFormat>( 73 scoped_refptr<base::trace_event::ConvertableToTraceFormat>(
73 new TracedValue(params.Pass()))); 74 new TracedValue(std::move(params))));
74 break; 75 break;
75 case NetLog::PHASE_NONE: 76 case NetLog::PHASE_NONE:
76 TRACE_EVENT_NESTABLE_ASYNC_INSTANT2( 77 TRACE_EVENT_NESTABLE_ASYNC_INSTANT2(
77 kNetLogTracingCategory, NetLog::EventTypeToString(entry.type()), 78 kNetLogTracingCategory, NetLog::EventTypeToString(entry.type()),
78 entry.source().id, "source_type", 79 entry.source().id, "source_type",
79 NetLog::SourceTypeToString(entry.source().type), "params", 80 NetLog::SourceTypeToString(entry.source().type), "params",
80 scoped_refptr<base::trace_event::ConvertableToTraceFormat>( 81 scoped_refptr<base::trace_event::ConvertableToTraceFormat>(
81 new TracedValue(params.Pass()))); 82 new TracedValue(std::move(params))));
82 break; 83 break;
83 } 84 }
84 } 85 }
85 86
86 void TraceNetLogObserver::WatchForTraceStart(NetLog* netlog) { 87 void TraceNetLogObserver::WatchForTraceStart(NetLog* netlog) {
87 DCHECK(!net_log_to_watch_); 88 DCHECK(!net_log_to_watch_);
88 DCHECK(!net_log()); 89 DCHECK(!net_log());
89 net_log_to_watch_ = netlog; 90 net_log_to_watch_ = netlog;
90 base::trace_event::TraceLog::GetInstance()->AddEnabledStateObserver(this); 91 base::trace_event::TraceLog::GetInstance()->AddEnabledStateObserver(this);
91 } 92 }
(...skipping 10 matching lines...) Expand all
102 void TraceNetLogObserver::OnTraceLogEnabled() { 103 void TraceNetLogObserver::OnTraceLogEnabled() {
103 net_log_to_watch_->DeprecatedAddObserver(this, NetLogCaptureMode::Default()); 104 net_log_to_watch_->DeprecatedAddObserver(this, NetLogCaptureMode::Default());
104 } 105 }
105 106
106 void TraceNetLogObserver::OnTraceLogDisabled() { 107 void TraceNetLogObserver::OnTraceLogDisabled() {
107 if (net_log()) 108 if (net_log())
108 net_log()->DeprecatedRemoveObserver(this); 109 net_log()->DeprecatedRemoveObserver(this);
109 } 110 }
110 111
111 } // namespace net 112 } // namespace net
OLDNEW
« no previous file with comments | « net/log/test_net_log_entry.cc ('k') | net/log/trace_net_log_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698