Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: net/dns/host_resolver_mojo_unittest.cc

Issue 1545233002: Convert Pass()→std::move() in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/dns/host_resolver_mojo.cc ('k') | net/dns/mapped_host_resolver.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/dns/host_resolver_mojo.h" 5 #include "net/dns/host_resolver_mojo.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility>
8 9
9 #include "mojo/public/cpp/bindings/binding.h" 10 #include "mojo/public/cpp/bindings/binding.h"
10 #include "net/base/address_list.h" 11 #include "net/base/address_list.h"
11 #include "net/base/net_errors.h" 12 #include "net/base/net_errors.h"
12 #include "net/base/request_priority.h" 13 #include "net/base/request_priority.h"
13 #include "net/base/test_completion_callback.h" 14 #include "net/base/test_completion_callback.h"
14 #include "net/dns/mojo_host_type_converters.h" 15 #include "net/dns/mojo_host_type_converters.h"
15 #include "net/test/event_waiter.h" 16 #include "net/test/event_waiter.h"
16 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
17 18
(...skipping 11 matching lines...) Expand all
29 void OnConnectionError(); 30 void OnConnectionError();
30 31
31 private: 32 private:
32 interfaces::HostResolverRequestClientPtr client_; 33 interfaces::HostResolverRequestClientPtr client_;
33 const base::Closure error_callback_; 34 const base::Closure error_callback_;
34 }; 35 };
35 36
36 MockMojoHostResolverRequest::MockMojoHostResolverRequest( 37 MockMojoHostResolverRequest::MockMojoHostResolverRequest(
37 interfaces::HostResolverRequestClientPtr client, 38 interfaces::HostResolverRequestClientPtr client,
38 const base::Closure& error_callback) 39 const base::Closure& error_callback)
39 : client_(client.Pass()), error_callback_(error_callback) { 40 : client_(std::move(client)), error_callback_(error_callback) {
40 client_.set_connection_error_handler(base::Bind( 41 client_.set_connection_error_handler(base::Bind(
41 &MockMojoHostResolverRequest::OnConnectionError, base::Unretained(this))); 42 &MockMojoHostResolverRequest::OnConnectionError, base::Unretained(this)));
42 } 43 }
43 44
44 void MockMojoHostResolverRequest::OnConnectionError() { 45 void MockMojoHostResolverRequest::OnConnectionError() {
45 error_callback_.Run(); 46 error_callback_.Run();
46 } 47 }
47 48
48 struct HostResolverAction { 49 struct HostResolverAction {
49 enum Action { 50 enum Action {
50 COMPLETE, 51 COMPLETE,
51 DROP, 52 DROP,
52 RETAIN, 53 RETAIN,
53 }; 54 };
54 55
55 static scoped_ptr<HostResolverAction> ReturnError(Error error) { 56 static scoped_ptr<HostResolverAction> ReturnError(Error error) {
56 scoped_ptr<HostResolverAction> result(new HostResolverAction); 57 scoped_ptr<HostResolverAction> result(new HostResolverAction);
57 result->error = error; 58 result->error = error;
58 return result.Pass(); 59 return result;
59 } 60 }
60 61
61 static scoped_ptr<HostResolverAction> ReturnResult( 62 static scoped_ptr<HostResolverAction> ReturnResult(
62 const AddressList& address_list) { 63 const AddressList& address_list) {
63 scoped_ptr<HostResolverAction> result(new HostResolverAction); 64 scoped_ptr<HostResolverAction> result(new HostResolverAction);
64 result->addresses = interfaces::AddressList::From(address_list); 65 result->addresses = interfaces::AddressList::From(address_list);
65 return result.Pass(); 66 return result;
66 } 67 }
67 68
68 static scoped_ptr<HostResolverAction> DropRequest() { 69 static scoped_ptr<HostResolverAction> DropRequest() {
69 scoped_ptr<HostResolverAction> result(new HostResolverAction); 70 scoped_ptr<HostResolverAction> result(new HostResolverAction);
70 result->action = DROP; 71 result->action = DROP;
71 return result.Pass(); 72 return result;
72 } 73 }
73 74
74 static scoped_ptr<HostResolverAction> RetainRequest() { 75 static scoped_ptr<HostResolverAction> RetainRequest() {
75 scoped_ptr<HostResolverAction> result(new HostResolverAction); 76 scoped_ptr<HostResolverAction> result(new HostResolverAction);
76 result->action = RETAIN; 77 result->action = RETAIN;
77 return result.Pass(); 78 return result;
78 } 79 }
79 80
80 Action action = COMPLETE; 81 Action action = COMPLETE;
81 interfaces::AddressListPtr addresses; 82 interfaces::AddressListPtr addresses;
82 Error error = OK; 83 Error error = OK;
83 }; 84 };
84 85
85 class MockMojoHostResolver : public HostResolverMojo::Impl { 86 class MockMojoHostResolver : public HostResolverMojo::Impl {
86 public: 87 public:
87 explicit MockMojoHostResolver( 88 explicit MockMojoHostResolver(
(...skipping 20 matching lines...) Expand all
108 MockMojoHostResolver::MockMojoHostResolver( 109 MockMojoHostResolver::MockMojoHostResolver(
109 const base::Closure& request_connection_error_callback) 110 const base::Closure& request_connection_error_callback)
110 : request_connection_error_callback_(request_connection_error_callback) { 111 : request_connection_error_callback_(request_connection_error_callback) {
111 } 112 }
112 113
113 MockMojoHostResolver::~MockMojoHostResolver() { 114 MockMojoHostResolver::~MockMojoHostResolver() {
114 EXPECT_EQ(results_returned_, actions_.size()); 115 EXPECT_EQ(results_returned_, actions_.size());
115 } 116 }
116 117
117 void MockMojoHostResolver::AddAction(scoped_ptr<HostResolverAction> action) { 118 void MockMojoHostResolver::AddAction(scoped_ptr<HostResolverAction> action) {
118 actions_.push_back(action.Pass()); 119 actions_.push_back(std::move(action));
119 } 120 }
120 121
121 void MockMojoHostResolver::ResolveDns( 122 void MockMojoHostResolver::ResolveDns(
122 interfaces::HostResolverRequestInfoPtr request_info, 123 interfaces::HostResolverRequestInfoPtr request_info,
123 interfaces::HostResolverRequestClientPtr client) { 124 interfaces::HostResolverRequestClientPtr client) {
124 requests_received_.push_back(request_info.Pass()); 125 requests_received_.push_back(std::move(request_info));
125 ASSERT_LE(results_returned_, actions_.size()); 126 ASSERT_LE(results_returned_, actions_.size());
126 switch (actions_[results_returned_]->action) { 127 switch (actions_[results_returned_]->action) {
127 case HostResolverAction::COMPLETE: 128 case HostResolverAction::COMPLETE:
128 client->ReportResult(actions_[results_returned_]->error, 129 client->ReportResult(actions_[results_returned_]->error,
129 actions_[results_returned_]->addresses.Pass()); 130 std::move(actions_[results_returned_]->addresses));
130 break; 131 break;
131 case HostResolverAction::RETAIN: 132 case HostResolverAction::RETAIN:
132 requests_.push_back(make_scoped_ptr(new MockMojoHostResolverRequest( 133 requests_.push_back(make_scoped_ptr(new MockMojoHostResolverRequest(
133 client.Pass(), request_connection_error_callback_))); 134 std::move(client), request_connection_error_callback_)));
134 break; 135 break;
135 case HostResolverAction::DROP: 136 case HostResolverAction::DROP:
136 client.reset(); 137 client.reset();
137 break; 138 break;
138 } 139 }
139 results_returned_++; 140 results_returned_++;
140 } 141 }
141 142
142 } // namespace 143 } // namespace
143 144
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 EXPECT_EQ(ERR_DNS_CACHE_MISS, 399 EXPECT_EQ(ERR_DNS_CACHE_MISS,
399 resolver_->ResolveFromCache(request_info, &result, BoundNetLog())); 400 resolver_->ResolveFromCache(request_info, &result, BoundNetLog()));
400 EXPECT_TRUE(result.empty()); 401 EXPECT_TRUE(result.empty());
401 } 402 }
402 403
403 TEST_F(HostResolverMojoTest, GetHostCache) { 404 TEST_F(HostResolverMojoTest, GetHostCache) {
404 EXPECT_TRUE(resolver_->GetHostCache()); 405 EXPECT_TRUE(resolver_->GetHostCache());
405 } 406 }
406 407
407 } // namespace net 408 } // namespace net
OLDNEW
« no previous file with comments | « net/dns/host_resolver_mojo.cc ('k') | net/dns/mapped_host_resolver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698