Issue 154523002: A64: Fix code patching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 154523002: A64: Fix code patching (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 10 months ago

Reviewers:
ulan, Rodolph Perfetta (ARM)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/a64

Visibility:
Public.

A64: Fix code patching - The offset passed to Assembler:B() is in number of instructions, not bytes - The ok label is actually 6 instructions after the B.pl - The imm of the load instruction must be relative to the load instruction R=ulan@chromium.org, rodolph.perfetta@arm.com BUG=none LOG=y Committed: https://code.google.com/p/v8/source/detail?r=19091

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -4 lines)			Patch
	M	src/a64/full-codegen-a64.cc	View	1	3 chunks	+32 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

jochen (gone - plz use gerrit)

PTAL The ASSERT() is a bit ugly, but it makes sure that we're indeed patching ...

6 years, 10 months ago (2014-02-05 08:26:28 UTC) #2

jochen (gone - plz use gerrit)

6 years, 10 months ago (2014-02-05 08:35:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r19091 (presubmit successful).