Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: chrome/browser/sync/glue/extensions_activity_monitor_unittest.cc

Issue 1545223002: Switch to standard integer types in chrome/browser/, part 4 of 4. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/glue/extensions_activity_monitor.h" 5 #include "chrome/browser/sync/glue/extensions_activity_monitor.h"
6 6
7 #include <stdint.h>
8
7 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
8 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
9 #include "base/path_service.h" 11 #include "base/path_service.h"
10 #include "base/values.h" 12 #include "base/values.h"
11 #include "chrome/browser/chrome_notification_types.h" 13 #include "chrome/browser/chrome_notification_types.h"
12 #include "chrome/browser/extensions/api/bookmarks/bookmarks_api.h" 14 #include "chrome/browser/extensions/api/bookmarks/bookmarks_api.h"
13 #include "chrome/common/chrome_paths.h" 15 #include "chrome/common/chrome_paths.h"
14 #include "content/public/browser/notification_service.h" 16 #include "content/public/browser/notification_service.h"
15 #include "content/public/test/test_browser_thread_bundle.h" 17 #include "content/public/test/test_browser_thread_bundle.h"
16 #include "extensions/common/extension.h" 18 #include "extensions/common/extension.h"
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 // Fire some mutating bookmark API events with extension 1, then fire 89 // Fire some mutating bookmark API events with extension 1, then fire
88 // some mutating and non-mutating bookmark API events with extension 90 // some mutating and non-mutating bookmark API events with extension
89 // 2. Only the mutating events should be recorded by the 91 // 2. Only the mutating events should be recorded by the
90 // syncer::ExtensionsActivityMonitor. 92 // syncer::ExtensionsActivityMonitor.
91 TEST_F(SyncChromeExtensionsActivityMonitorTest, DISABLED_Basic) { 93 TEST_F(SyncChromeExtensionsActivityMonitorTest, DISABLED_Basic) {
92 FireBookmarksApiEvent<extensions::BookmarksRemoveFunction>(extension1_, 1); 94 FireBookmarksApiEvent<extensions::BookmarksRemoveFunction>(extension1_, 1);
93 FireBookmarksApiEvent<extensions::BookmarksMoveFunction>(extension1_, 1); 95 FireBookmarksApiEvent<extensions::BookmarksMoveFunction>(extension1_, 1);
94 FireBookmarksApiEvent<extensions::BookmarksUpdateFunction>(extension1_, 2); 96 FireBookmarksApiEvent<extensions::BookmarksUpdateFunction>(extension1_, 2);
95 FireBookmarksApiEvent<extensions::BookmarksCreateFunction>(extension1_, 3); 97 FireBookmarksApiEvent<extensions::BookmarksCreateFunction>(extension1_, 3);
96 FireBookmarksApiEvent<extensions::BookmarksSearchFunction>(extension1_, 5); 98 FireBookmarksApiEvent<extensions::BookmarksSearchFunction>(extension1_, 5);
97 const uint32 writes_by_extension1 = 1 + 1 + 2 + 3; 99 const uint32_t writes_by_extension1 = 1 + 1 + 2 + 3;
98 100
99 FireBookmarksApiEvent<extensions::BookmarksRemoveTreeFunction>( 101 FireBookmarksApiEvent<extensions::BookmarksRemoveTreeFunction>(
100 extension2_, 8); 102 extension2_, 8);
101 FireBookmarksApiEvent<extensions::BookmarksGetSubTreeFunction>( 103 FireBookmarksApiEvent<extensions::BookmarksGetSubTreeFunction>(
102 extension2_, 13); 104 extension2_, 13);
103 FireBookmarksApiEvent<extensions::BookmarksGetChildrenFunction>( 105 FireBookmarksApiEvent<extensions::BookmarksGetChildrenFunction>(
104 extension2_, 21); 106 extension2_, 21);
105 FireBookmarksApiEvent<extensions::BookmarksGetTreeFunction>(extension2_, 33); 107 FireBookmarksApiEvent<extensions::BookmarksGetTreeFunction>(extension2_, 33);
106 const uint32 writes_by_extension2 = 8; 108 const uint32_t writes_by_extension2 = 8;
107 109
108 syncer::ExtensionsActivity::Records results; 110 syncer::ExtensionsActivity::Records results;
109 monitor_.GetExtensionsActivity()->GetAndClearRecords(&results); 111 monitor_.GetExtensionsActivity()->GetAndClearRecords(&results);
110 112
111 EXPECT_EQ(2U, results.size()); 113 EXPECT_EQ(2U, results.size());
112 EXPECT_TRUE(results.find(id1_) != results.end()); 114 EXPECT_TRUE(results.find(id1_) != results.end());
113 EXPECT_TRUE(results.find(id2_) != results.end()); 115 EXPECT_TRUE(results.find(id2_) != results.end());
114 EXPECT_EQ(writes_by_extension1, results[id1_].bookmark_write_count); 116 EXPECT_EQ(writes_by_extension1, results[id1_].bookmark_write_count);
115 EXPECT_EQ(writes_by_extension2, results[id2_].bookmark_write_count); 117 EXPECT_EQ(writes_by_extension2, results[id2_].bookmark_write_count);
116 } 118 }
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 FireBookmarksApiEvent<extensions::BookmarksCreateFunction>(extension1_, 3); 166 FireBookmarksApiEvent<extensions::BookmarksCreateFunction>(extension1_, 3);
165 monitor_.GetExtensionsActivity()->GetAndClearRecords(&results); 167 monitor_.GetExtensionsActivity()->GetAndClearRecords(&results);
166 168
167 EXPECT_EQ(1U, results.size()); 169 EXPECT_EQ(1U, results.size());
168 EXPECT_EQ(3U, results[id1_].bookmark_write_count); 170 EXPECT_EQ(3U, results[id1_].bookmark_write_count);
169 } 171 }
170 172
171 } // namespace 173 } // namespace
172 174
173 } // namespace browser_sync 175 } // namespace browser_sync
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698