Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1727)

Issue 1545203002: [wasm] Define the FP return register for X87. (Closed)

Created:
4 years, 12 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Define the FP return register for X87. The FP parameters for X87 should be put in stack and the FP return value should be put in stX_0 register. So this CL defines the FP_RETURN_REGISTERS as stX_0 only. BUG= Committed: https://crrev.com/007de5d2138d41102db99ec35e3c4cdde93e47df Cr-Commit-Position: refs/heads/master@{#33110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/compiler/wasm-linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
zhengxing.li
PTAL, Thanks!
4 years, 12 months ago (2015-12-25 07:19:19 UTC) #2
Weiliang
lgtm, but still need google's comment
4 years, 12 months ago (2015-12-28 05:59:17 UTC) #3
bradnelson
lgtm, but you'll need someone else to lg for commit.
4 years, 11 months ago (2016-01-04 23:08:29 UTC) #4
Benedikt Meurer
LGTM (rubber-stamped)
4 years, 11 months ago (2016-01-05 10:20:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545203002/1
4 years, 11 months ago (2016-01-05 10:37:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 11:22:00 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 11:22:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/007de5d2138d41102db99ec35e3c4cdde93e47df
Cr-Commit-Position: refs/heads/master@{#33110}

Powered by Google App Engine
This is Rietveld 408576698