chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc - Issue 1545153002: Switch to standard integer types in chrome/browser/ui/views/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

Issue 1545153002: Switch to standard integer types in chrome/browser/ui/views/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h ('k') | chrome/browser/ui/views/apps/app_window_desktop_native_widget_aura_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

index 531d5f9551ce61f398abd59032967ef0f40e0433..063d0059526e2ffa38d92a92d3c8fffef4a91998 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h"

+#include <stddef.h>

#include <vector>

#include "base/callback_forward.h"

@@ -11,6 +13,7 @@

#include "base/logging.h"

#include "base/strings/utf_string_conversions.h"

#include "base/task_runner_util.h"

+#include "build/build_config.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_util.h"

#include "chrome/browser/extensions/launch_util.h"

@@ -285,7 +288,7 @@ void AppInfoSummaryPanel::StartCalculatingAppSize() {

base::Bind(&AppInfoSummaryPanel::OnAppSizeCalculated, AsWeakPtr()));

}

-void AppInfoSummaryPanel::OnAppSizeCalculated(int64 app_size_in_bytes) {

+void AppInfoSummaryPanel::OnAppSizeCalculated(int64_t app_size_in_bytes) {

const int one_mebibyte_in_bytes = 1024 * 1024;

if (app_size_in_bytes < one_mebibyte_in_bytes) {

size_value_->SetText(