Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 1545153002: Switch to standard integer types in chrome/browser/ui/views/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h" 5 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/metrics/histogram.h" 11 #include "base/metrics/histogram.h"
12 #include "base/strings/string_util.h" 12 #include "base/strings/string_util.h"
13 #include "base/strings/utf_string_conversions.h" 13 #include "base/strings/utf_string_conversions.h"
14 #include "build/build_config.h"
14 #include "chrome/app/chrome_command_ids.h" 15 #include "chrome/app/chrome_command_ids.h"
15 #include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h" 16 #include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"
16 #include "chrome/browser/command_updater.h" 17 #include "chrome/browser/command_updater.h"
17 #include "chrome/browser/search/search.h" 18 #include "chrome/browser/search/search.h"
18 #include "chrome/browser/ui/omnibox/chrome_omnibox_client.h" 19 #include "chrome/browser/ui/omnibox/chrome_omnibox_client.h"
19 #include "chrome/browser/ui/omnibox/clipboard_utils.h" 20 #include "chrome/browser/ui/omnibox/clipboard_utils.h"
20 #include "chrome/browser/ui/view_ids.h" 21 #include "chrome/browser/ui/view_ids.h"
21 #include "chrome/browser/ui/views/location_bar/location_bar_view.h" 22 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
22 #include "chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h" 23 #include "chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h"
23 #include "chrome/browser/ui/views/settings_api_bubble_helper_views.h" 24 #include "chrome/browser/ui/views/settings_api_bubble_helper_views.h"
(...skipping 1046 matching lines...) Expand 10 before | Expand all | Expand 10 after
1070 menu_contents->InsertItemWithStringIdAt( 1071 menu_contents->InsertItemWithStringIdAt(
1071 select_all_position + 1, IDS_SHOW_URL, IDS_SHOW_URL); 1072 select_all_position + 1, IDS_SHOW_URL, IDS_SHOW_URL);
1072 } 1073 }
1073 1074
1074 // Minor note: We use IDC_ for command id here while the underlying textfield 1075 // Minor note: We use IDC_ for command id here while the underlying textfield
1075 // is using IDS_ for all its command ids. This is because views cannot depend 1076 // is using IDS_ for all its command ids. This is because views cannot depend
1076 // on IDC_ for now. 1077 // on IDC_ for now.
1077 menu_contents->AddItemWithStringId(IDC_EDIT_SEARCH_ENGINES, 1078 menu_contents->AddItemWithStringId(IDC_EDIT_SEARCH_ENGINES,
1078 IDS_EDIT_SEARCH_ENGINES); 1079 IDS_EDIT_SEARCH_ENGINES);
1079 } 1080 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698