Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 15451002: Start collecting two new WebSocket histograms. (Closed)

Created:
7 years, 7 months ago by tyoshino (SeeGerritForStatus)
Modified:
7 years, 7 months ago
Reviewers:
yhirano
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

Start collecting two new WebSocket histograms. - WebCore.WebSocket.HandshakeResult: to know how many WebSockets are successfully established. - WebCore.WebSocket.PerMessageDeflateMode: to know the servers' adoption rate of the permessage-deflate extension including no_context_takeover option usage. BUG=128156 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150734

Patch Set 1 #

Patch Set 2 : Comment update #

Patch Set 3 : Delete enum #

Patch Set 4 : More descriptive histogram name #

Patch Set 5 : Retry #

Total comments: 2

Patch Set 6 : Add comment about reset() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M Source/modules/websockets/WebSocketDeflater.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M Source/modules/websockets/WebSocketHandshake.h View 1 2 3 4 5 2 chunks +6 lines, -1 line 0 comments Download
M Source/modules/websockets/WebSocketHandshake.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/websockets/WebSocketPerMessageDeflate.cpp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tyoshino (SeeGerritForStatus)
7 years, 7 months ago (2013-05-20 08:37:53 UTC) #1
tyoshino (SeeGerritForStatus)
Code change https://codereview.chromium.org/15380004/
7 years, 7 months ago (2013-05-20 09:13:53 UTC) #2
tyoshino (SeeGerritForStatus)
On 2013/05/20 09:13:53, tyoshino wrote: > Code change > https://codereview.chromium.org/15380004/ Sorry, this is histogram change.
7 years, 7 months ago (2013-05-20 09:14:29 UTC) #3
yhirano
lgtm https://codereview.chromium.org/15451002/diff/6001/Source/modules/websockets/WebSocketHandshake.cpp File Source/modules/websockets/WebSocketHandshake.cpp (right): https://codereview.chromium.org/15451002/diff/6001/Source/modules/websockets/WebSocketHandshake.cpp#newcode276 Source/modules/websockets/WebSocketHandshake.cpp:276: void WebSocketHandshake::reset() (optional) Adding a comment (here or ...
7 years, 7 months ago (2013-05-20 09:44:02 UTC) #4
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/15451002/diff/6001/Source/modules/websockets/WebSocketHandshake.cpp File Source/modules/websockets/WebSocketHandshake.cpp (right): https://codereview.chromium.org/15451002/diff/6001/Source/modules/websockets/WebSocketHandshake.cpp#newcode276 Source/modules/websockets/WebSocketHandshake.cpp:276: void WebSocketHandshake::reset() On 2013/05/20 09:44:02, yhirano wrote: > (optional) ...
7 years, 7 months ago (2013-05-20 09:57:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/15451002/13001
7 years, 7 months ago (2013-05-21 00:59:26 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 02:08:34 UTC) #7
Message was sent while issue was closed.
Change committed as 150734

Powered by Google App Engine
This is Rietveld 408576698