Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1545053002: X87: Partial revert of rest parameter desugaring. (Closed)

Created:
4 years, 12 months ago by zhengxing.li
Modified:
4 years, 12 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Partial revert of rest parameter desugaring. port d3f074b23195a2426d14298dca30c4cf9183f203 (r33024) original commit message: We'll be able to optimize rest parameters in TurboFan similarly to the arguments array. This CL restores the previous behavior, and a follow-on will enable TurboFan optimization. (TBR for rossberg since we discussed the revert beforehand. The only changes are a few lines related to tests and rebasing.) BUG= Committed: https://crrev.com/d9cfa7293def832000881ef1db7548051ee2815b Cr-Commit-Position: refs/heads/master@{#33034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL
4 years, 12 months ago (2015-12-24 02:24:17 UTC) #2
Weiliang
lgtm
4 years, 12 months ago (2015-12-24 07:49:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545053002/1
4 years, 12 months ago (2015-12-24 07:49:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-24 08:07:07 UTC) #6
commit-bot: I haz the power
4 years, 12 months ago (2015-12-24 08:07:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9cfa7293def832000881ef1db7548051ee2815b
Cr-Commit-Position: refs/heads/master@{#33034}

Powered by Google App Engine
This is Rietveld 408576698