Relanding fix from ea9b0ba419a3598bdb7f7c62afdf4409afa73ab1

Relanding fix from ea9b0ba419a3598bdb7f7c62afdf4409afa73ab1

This fix got reverted by accident in 502a5c9660bfd1c2ac949e4388bc8697d06b5507

TBR=pkasting

Original fix description:

Updated DropdownBarHost to use Layer clipping instead of OnPaint() clipping.

The Material Design ink drop ripple was recently applied to the material
design find in page dialog (https://codereview.chromium.org/1396903003).
This change required that some Views to paint to layers unfortunately
the clipping mechanism used for the find in page bar only applied to the
OnPaint() methods and did not work to clip layer trees.

This CL sets the contents view for the DropdownBarHost::widget_ to be a
new clipping view, and the FindBarView is added as a child to the
clipping view instead of as the DropdownBarHost::widget_'s contents view.

This CL has the added benefit that the the drop down bars will not need
to be repainted anymore for each animation frame.

TEST=Open the find in page bar with material design turned on. Click and
hold on the close button so the ink drop ripple is visible. Hit the Esc
key to dismiss the dialog.  The back button/ripple should not appear over
top of the toolbar and should be clipped at the same horizontal line as
the rest of the dialog.

BUG=549621
Review URL: https://codereview.chromium.org/1472023004

Cr-Commit-Position: refs/heads/master@{#361695}

Committed: https://crrev.com/411c95ff5cd0aa903d812765b22d348bb9f5f4d1
Cr-Commit-Position: refs/heads/master@{#366767}

[bruthig, 2015-12-23 19:42:37]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2015-12-23 19:43:04]

Description was changed from

==========
Relanding fix from ea9b0ba419a3598bdb7f7c62afdf4409afa73ab1

This fix got reverted by accident in 502a5c9660bfd1c2ac949e4388bc8697d06b5507

Original fix description:

Updated DropdownBarHost to use Layer clipping instead of OnPaint() clipping.

The Material Design ink drop ripple was recently applied to the material
design find in page dialog (https://codereview.chromium.org/1396903003).
This change required that some Views to paint to layers unfortunately
the clipping mechanism used for the find in page bar only applied to the
OnPaint() methods and did not work to clip layer trees.

This CL sets the contents view for the DropdownBarHost::widget_ to be a
new clipping view, and the FindBarView is added as a child to the
clipping view instead of as the DropdownBarHost::widget_'s contents view.

This CL has the added benefit that the the drop down bars will not need
to be repainted anymore for each animation frame.

TEST=Open the find in page bar with material design turned on. Click and
hold on the close button so the ink drop ripple is visible. Hit the Esc
key to dismiss the dialog.  The back button/ripple should not appear over
top of the toolbar and should be clipped at the same horizontal line as
the rest of the dialog.

BUG=549621

Review URL: https://codereview.chromium.org/1472023004

Cr-Commit-Position: refs/heads/master@{#361695}
==========

to

==========
Relanding fix from ea9b0ba419a3598bdb7f7c62afdf4409afa73ab1

This fix got reverted by accident in 502a5c9660bfd1c2ac949e4388bc8697d06b5507

TBR=pkasting

Original fix description:

Updated DropdownBarHost to use Layer clipping instead of OnPaint() clipping.

The Material Design ink drop ripple was recently applied to the material
design find in page dialog (https://codereview.chromium.org/1396903003).
This change required that some Views to paint to layers unfortunately
the clipping mechanism used for the find in page bar only applied to the
OnPaint() methods and did not work to clip layer trees.

This CL sets the contents view for the DropdownBarHost::widget_ to be a
new clipping view, and the FindBarView is added as a child to the
clipping view instead of as the DropdownBarHost::widget_'s contents view.

This CL has the added benefit that the the drop down bars will not need
to be repainted anymore for each animation frame.

TEST=Open the find in page bar with material design turned on. Click and
hold on the close button so the ink drop ripple is visible. Hit the Esc
key to dismiss the dialog.  The back button/ripple should not appear over
top of the toolbar and should be clipped at the same horizontal line as
the rest of the dialog.

BUG=549621

Review URL: https://codereview.chromium.org/1472023004

Cr-Commit-Position: refs/heads/master@{#361695}
==========

[commit-bot: I haz the power, 2015-12-23 19:43:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545023002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545023002/1

[bruthig, 2015-12-23 19:43:44]

bruthig@chromium.org changed reviewers:
+ pkasting@chromium.org

[bruthig, 2015-12-23 19:43:45]

pkasting@, I marked you as TBR on this one so take a look if you wish.  This is
simply re-landing a fix that you already lgtm'ed that I accidentally reverted.

[commit-bot: I haz the power, 2015-12-23 20:35:45]

Description was changed from

==========
Relanding fix from ea9b0ba419a3598bdb7f7c62afdf4409afa73ab1

This fix got reverted by accident in 502a5c9660bfd1c2ac949e4388bc8697d06b5507

TBR=pkasting

Original fix description:

Updated DropdownBarHost to use Layer clipping instead of OnPaint() clipping.

The Material Design ink drop ripple was recently applied to the material
design find in page dialog (https://codereview.chromium.org/1396903003).
This change required that some Views to paint to layers unfortunately
the clipping mechanism used for the find in page bar only applied to the
OnPaint() methods and did not work to clip layer trees.

This CL sets the contents view for the DropdownBarHost::widget_ to be a
new clipping view, and the FindBarView is added as a child to the
clipping view instead of as the DropdownBarHost::widget_'s contents view.

This CL has the added benefit that the the drop down bars will not need
to be repainted anymore for each animation frame.

TEST=Open the find in page bar with material design turned on. Click and
hold on the close button so the ink drop ripple is visible. Hit the Esc
key to dismiss the dialog.  The back button/ripple should not appear over
top of the toolbar and should be clipped at the same horizontal line as
the rest of the dialog.

BUG=549621

Review URL: https://codereview.chromium.org/1472023004

Cr-Commit-Position: refs/heads/master@{#361695}
==========

to

==========
Relanding fix from ea9b0ba419a3598bdb7f7c62afdf4409afa73ab1

This fix got reverted by accident in 502a5c9660bfd1c2ac949e4388bc8697d06b5507

TBR=pkasting

Original fix description:

Updated DropdownBarHost to use Layer clipping instead of OnPaint() clipping.

The Material Design ink drop ripple was recently applied to the material
design find in page dialog (https://codereview.chromium.org/1396903003).
This change required that some Views to paint to layers unfortunately
the clipping mechanism used for the find in page bar only applied to the
OnPaint() methods and did not work to clip layer trees.

This CL sets the contents view for the DropdownBarHost::widget_ to be a
new clipping view, and the FindBarView is added as a child to the
clipping view instead of as the DropdownBarHost::widget_'s contents view.

This CL has the added benefit that the the drop down bars will not need
to be repainted anymore for each animation frame.

TEST=Open the find in page bar with material design turned on. Click and
hold on the close button so the ink drop ripple is visible. Hit the Esc
key to dismiss the dialog.  The back button/ripple should not appear over
top of the toolbar and should be clipped at the same horizontal line as
the rest of the dialog.

BUG=549621

Review URL: https://codereview.chromium.org/1472023004

Cr-Commit-Position: refs/heads/master@{#361695}
==========

[commit-bot: I haz the power, 2015-12-23 20:35:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-23 20:36:52]

Description was changed from

==========
Relanding fix from ea9b0ba419a3598bdb7f7c62afdf4409afa73ab1

This fix got reverted by accident in 502a5c9660bfd1c2ac949e4388bc8697d06b5507

TBR=pkasting

Original fix description:

Updated DropdownBarHost to use Layer clipping instead of OnPaint() clipping.

The Material Design ink drop ripple was recently applied to the material
design find in page dialog (https://codereview.chromium.org/1396903003).
This change required that some Views to paint to layers unfortunately
the clipping mechanism used for the find in page bar only applied to the
OnPaint() methods and did not work to clip layer trees.

This CL sets the contents view for the DropdownBarHost::widget_ to be a
new clipping view, and the FindBarView is added as a child to the
clipping view instead of as the DropdownBarHost::widget_'s contents view.

This CL has the added benefit that the the drop down bars will not need
to be repainted anymore for each animation frame.

TEST=Open the find in page bar with material design turned on. Click and
hold on the close button so the ink drop ripple is visible. Hit the Esc
key to dismiss the dialog.  The back button/ripple should not appear over
top of the toolbar and should be clipped at the same horizontal line as
the rest of the dialog.

BUG=549621

Review URL: https://codereview.chromium.org/1472023004

Cr-Commit-Position: refs/heads/master@{#361695}
==========

to

==========
Relanding fix from ea9b0ba419a3598bdb7f7c62afdf4409afa73ab1

This fix got reverted by accident in 502a5c9660bfd1c2ac949e4388bc8697d06b5507

TBR=pkasting

Original fix description:

Updated DropdownBarHost to use Layer clipping instead of OnPaint() clipping.

The Material Design ink drop ripple was recently applied to the material
design find in page dialog (https://codereview.chromium.org/1396903003).
This change required that some Views to paint to layers unfortunately
the clipping mechanism used for the find in page bar only applied to the
OnPaint() methods and did not work to clip layer trees.

This CL sets the contents view for the DropdownBarHost::widget_ to be a
new clipping view, and the FindBarView is added as a child to the
clipping view instead of as the DropdownBarHost::widget_'s contents view.

This CL has the added benefit that the the drop down bars will not need
to be repainted anymore for each animation frame.

TEST=Open the find in page bar with material design turned on. Click and
hold on the close button so the ink drop ripple is visible. Hit the Esc
key to dismiss the dialog.  The back button/ripple should not appear over
top of the toolbar and should be clipped at the same horizontal line as
the rest of the dialog.

BUG=549621

Review URL: https://codereview.chromium.org/1472023004

Cr-Commit-Position: refs/heads/master@{#361695}

Committed: https://crrev.com/411c95ff5cd0aa903d812765b22d348bb9f5f4d1
Cr-Commit-Position: refs/heads/master@{#366767}
==========

[commit-bot: I haz the power, 2015-12-23 20:36:53]

Patchset 1 (id:??) landed as
https://crrev.com/411c95ff5cd0aa903d812765b22d348bb9f5f4d1
Cr-Commit-Position: refs/heads/master@{#366767}