Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1545003003: [Interpreter] Fixes VisitNewLocalBlockContext to reserve consecutive registers. (Closed)

Created:
4 years, 12 months ago by mythria
Modified:
4 years, 11 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fixes VisitNewLocalBlockContext to reserve consecutive registers. VisitNewLocalBlockContext funciton was allocating two registers and checking if they are consecutive. This cl changes it to reserve consecutive registers. The earlier code breaks this test mjsunit/regress/regress-542099.js. BUG=v8:4280 LOG=N Committed: https://crrev.com/f7be4de9bc84ab899e008a90c7d2774498284990 Cr-Commit-Position: refs/heads/master@{#33086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mythria
I did not update mjsunit.status because, this still does not fix the test. The test ...
4 years, 11 months ago (2016-01-04 13:36:17 UTC) #2
rmcilroy
LGTM, thanks!
4 years, 11 months ago (2016-01-04 14:58:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545003003/1
4 years, 11 months ago (2016-01-04 15:52:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 15:53:52 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 15:54:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7be4de9bc84ab899e008a90c7d2774498284990
Cr-Commit-Position: refs/heads/master@{#33086}

Powered by Google App Engine
This is Rietveld 408576698