Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1544973002: Document lifecycle violation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Backtrack to only update comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index f94c98e4a4d0d191a3bc6a8fe84aaa561a7a9e1b..97f45123cf8274833840fdbd6677b977fd68c01c 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -2584,10 +2584,8 @@ void FrameView::updateStyleAndLayoutIfNeededRecursive()
for (const auto& frameView : frameViews)
frameView->updateStyleAndLayoutIfNeededRecursive();
- // When an <iframe> gets composited, it triggers an extra style recalc in its containing FrameView.
- // To avoid pushing an invalid tree for display, we have to check for this case and do another
- // style recalc. The extra style recalc needs to happen after our child <iframes> were updated.
- // FIXME: We shouldn't be triggering an extra style recalc in the first place.
+ // When SVG filters are invalidated using Document::scheduleSVGFilterLayerUpdateHack() they may trigger an
+ // extra style recalc. See PaintLayer::filterNeedsPaintInvalidation().
if (m_frame->document()->hasSVGFilterElementsRequiringLayerUpdate()) {
m_frame->document()->updateLayoutTreeIfNeeded();
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698