Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 1544973002: Document lifecycle violation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move marked further downstream instead. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
index d19defbd4862750dc61e387204c8a1444f7d2969..ddf4791152cc0f5690eef921e40f35e59d8ca399 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
@@ -49,7 +49,6 @@
#include "core/css/PseudoStyleRequest.h"
#include "core/dom/Document.h"
#include "core/dom/shadow/ShadowRoot.h"
-#include "core/frame/DeprecatedScheduleStyleRecalcDuringLayout.h"
#include "core/frame/FrameView.h"
#include "core/frame/LocalFrame.h"
#include "core/html/HTMLFrameElement.h"
@@ -2708,15 +2707,7 @@ void PaintLayer::updateOrRemoveFilterEffectBuilder()
void PaintLayer::filterNeedsPaintInvalidation()
{
- {
- DeprecatedScheduleStyleRecalcDuringLayout marker(layoutObject()->document().lifecycle());
- // It's possible for scheduleSVGFilterLayerUpdateHack to schedule a style recalc, which
- // is a problem because this function can be called while performing layout.
- // Presumably this represents an illegal data flow of layout or compositing
- // information into the style system.
- toElement(layoutObject()->node())->scheduleSVGFilterLayerUpdateHack();
- }
-
+ toElement(layoutObject()->node())->scheduleSVGFilterLayerUpdateHack();
layoutObject()->setShouldDoFullPaintInvalidation();
}

Powered by Google App Engine
This is Rietveld 408576698