Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1544973002: Document lifecycle violation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move marked further downstream instead. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index f0b373487b502c3973dbca8ac8075b92b10eb91b..11c199f977fc8a620a516f44432a0c8a8fe993ea 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -120,6 +120,7 @@
#include "core/events/ScopedEventQueue.h"
#include "core/fetch/ResourceFetcher.h"
#include "core/frame/DOMTimer.h"
+#include "core/frame/DeprecatedScheduleStyleRecalcDuringLayout.h"
#include "core/frame/EventHandlerRegistry.h"
#include "core/frame/FrameConsole.h"
#include "core/frame/FrameHost.h"
@@ -2101,6 +2102,10 @@ void Document::scheduleSVGFilterLayerUpdateHack(Element& element)
return;
element.setSVGFilterNeedsLayerUpdate();
m_layerUpdateSVGFilterElements.add(&element);
+
+ DeprecatedScheduleStyleRecalcDuringLayout marker(lifecycle());
esprehn 2016/01/22 19:24:44 Yeah this is supposed to be forced on all the user
+ // This function can sometimes be called while performing layout,
+ // e.g. when invalidating filters because of relative lengths.
scheduleLayoutTreeUpdateIfNeeded();
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698