core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp - Issue 1544963002: Clean up misc nits found while fixing bugs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp

Issue 1544963002: Clean up misc nits found while fixing bugs. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp

index c855a7c5c2eab3611a9ff0d6dacb090a03d28c31..d7783e438b32ea9c71373cf2a99d4dc4109f4d05 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp

@@ -324,9 +324,7 @@ FX_BOOL PDF_DataDecode(const uint8_t* src_buf,

CFX_ByteString& ImageEncoding,

CPDF_Dictionary*& pImageParms,

FX_DWORD last_estimated_size,

- FX_BOOL bImageAcc)

+ FX_BOOL bImageAcc) {

CPDF_Object* pDecoder = pDict ? pDict->GetElementValue("Filter") : nullptr;

if (!pDecoder || (!pDecoder->IsArray() && !pDecoder->IsName()))

return FALSE;