Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1544943002: Roll DEPS for V8 to d95511c. (Closed)

Created:
5 years ago by Lei Zhang
Modified:
4 years, 11 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 3

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M DEPS View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
I think we'll need to do something like this CL, but the errors I posted ...
5 years ago (2015-12-23 00:37:20 UTC) #2
Lei Zhang
On 2015/12/23 00:37:20, Lei Zhang wrote: > I think we'll need to do something like ...
4 years, 12 months ago (2015-12-24 10:17:35 UTC) #3
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1544943002/diff/20001/DEPS File DEPS (right): https://codereview.chromium.org/1544943002/diff/20001/DEPS#newcode25 DEPS:25: "v8/base/trace_event/common": i'm surprised that this is v8/base/... and not ...
4 years, 11 months ago (2016-01-08 14:48:20 UTC) #4
Lei Zhang
https://codereview.chromium.org/1544943002/diff/20001/DEPS File DEPS (right): https://codereview.chromium.org/1544943002/diff/20001/DEPS#newcode25 DEPS:25: "v8/base/trace_event/common": On 2016/01/08 14:48:20, jochen wrote: > i'm surprised ...
4 years, 11 months ago (2016-01-08 22:18:29 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2016-01-11 12:10:41 UTC) #6
Lei Zhang
4 years, 11 months ago (2016-01-11 20:02:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
494ea0af63620c6839f724111d0b955cbe93e1c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698