chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java - Issue 1544863003: Add Opt-in notification UMA for the Physical Web

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

Issue 1544863003: Add Opt-in notification UMA for the Physical Web (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

index d32d6b933c54463c638e9e20ce1e7f0c27db4e0b..45924a7f66a3fb2697139fb5dd3efa85d86f0691 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

@@ -277,9 +277,11 @@ class UrlManager {

// high priority notification

createOptInNotification(true);

PhysicalWeb.recordOptInNotification(mContext);

+ PhysicalWebUma.onOptInHighPriorityNotificationShown(mContext);

} else {

// min priority notification

createOptInNotification(false);

+ PhysicalWebUma.onOptInMinPriorityNotificationShown(mContext);

}

return;

}