Let content embedders register in-process media service.

Let content embedders register in-process media service.

This change makes the registration of in-process media service consistent with that of out-of-process service.

BUG=571155
Committed: https://crrev.com/6ecb238a745add6bf871e1b7b294696d6daa1f29
Cr-Commit-Position: refs/heads/master@{#371662}

[alokp, 2016-01-22 22:39:56]

Description was changed from

==========
Let content embedders register in-process media service.

BUG=571155
==========

to

==========
Let content embedders register in-process media service.

This change makes the registration of in-process media service consistent with
that of out-of-process service.

BUG=571155
==========

[alokp, 2016-01-22 22:40:45]

alokp@chromium.org changed reviewers:
+ rockot@chromium.org, xhwang@chromium.org

[xhwang, 2016-01-22 23:58:20]

Ken and I chatted about the possibility of having a unified function to register
all in-process and out-process applications. It'll be something like a map of
URLs to loaders. Or probably just URL to enums (e.g. BROWSER, UTILITY, GPU). But
I never got the chance to figure out details.

That being said, this CL lgtm. But please wait for Ken's comment as well.

https://chromiumcodereview.appspot.com/1544853003/diff/20001/content/browser/...
File content/browser/mojo/mojo_shell_context.cc (right):

https://chromiumcodereview.appspot.com/1544853003/diff/20001/content/browser/...
content/browser/mojo/mojo_shell_context.cc:252: GURL("mojo:media"));
FYI, we should move this to a registration call as well.

[Ken Rockot(use gerrit already), 2016-01-26 01:37:54]

sorry for the delay. lgtm modulo xhwang's comments and owner review

[alokp, 2016-01-26 07:32:28]

https://chromiumcodereview.appspot.com/1544853003/diff/20001/content/browser/...
File content/browser/mojo/mojo_shell_context.cc (right):

https://chromiumcodereview.appspot.com/1544853003/diff/20001/content/browser/...
content/browser/mojo/mojo_shell_context.cc:252: GURL("mojo:media"));
On 2016/01/22 23:58:20, xhwang wrote:
> FYI, we should move this to a registration call as well.

Do you mean RegisterGpuProcessMojoApplications?

[xhwang, 2016-01-26 17:32:25]

https://chromiumcodereview.appspot.com/1544853003/diff/20001/content/browser/...
File content/browser/mojo/mojo_shell_context.cc (right):

https://chromiumcodereview.appspot.com/1544853003/diff/20001/content/browser/...
content/browser/mojo/mojo_shell_context.cc:252: GURL("mojo:media"));
On 2016/01/26 07:32:28, alokp wrote:
> On 2016/01/22 23:58:20, xhwang wrote:
> > FYI, we should move this to a registration call as well.
> 
> Do you mean RegisterGpuProcessMojoApplications?

Yes, that would work. Then in the future we should try to consolidate these
Register*MojoApplications methods. Thanks!

[alokp, 2016-01-26 18:32:43]

On 2016/01/26 17:32:25, xhwang wrote:
>
https://chromiumcodereview.appspot.com/1544853003/diff/20001/content/browser/...
> File content/browser/mojo/mojo_shell_context.cc (right):
> 
>
https://chromiumcodereview.appspot.com/1544853003/diff/20001/content/browser/...
> content/browser/mojo/mojo_shell_context.cc:252: GURL("mojo:media"));
> On 2016/01/26 07:32:28, alokp wrote:
> > On 2016/01/22 23:58:20, xhwang wrote:
> > > FYI, we should move this to a registration call as well.
> > 
> > Do you mean RegisterGpuProcessMojoApplications?
> 
> Yes, that would work. Then in the future we should try to consolidate these
> Register*MojoApplications methods. Thanks!

I thought some more about refactoring app registration. I propose to:
- Leave in-process registration as it is because of the differences between
StaticApplicationMap and OutOfProcessMojoApplicationMap.
- Define OutOfProcessMojoApplicationMap as std::map<GURL, PROCESS> instead of
std::map<GURL, PROCESS_NAME>. In the case of utility process, we can derive a
reasonable PROCESS_NAME from GURL.

If you guys agree with the proposal, I think it is OK to land this patch as it
is because it deals with in-process registration only. Thoughts?

[alokp, 2016-01-26 18:38:22]

I also discussed offline with xhwang@ offline about support for unsandboxed
utility process. It was initially added for Chromecast, which we do not need for
now. So it is OK to drop this support when I refactor app registration.

[xhwang, 2016-01-26 18:40:30]

On 2016/01/26 18:32:43, alokp wrote:
> On 2016/01/26 17:32:25, xhwang wrote:
> >
>
https://chromiumcodereview.appspot.com/1544853003/diff/20001/content/browser/...
> > File content/browser/mojo/mojo_shell_context.cc (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/1544853003/diff/20001/content/browser/...
> > content/browser/mojo/mojo_shell_context.cc:252: GURL("mojo:media"));
> > On 2016/01/26 07:32:28, alokp wrote:
> > > On 2016/01/22 23:58:20, xhwang wrote:
> > > > FYI, we should move this to a registration call as well.
> > > 
> > > Do you mean RegisterGpuProcessMojoApplications?
> > 
> > Yes, that would work. Then in the future we should try to consolidate these
> > Register*MojoApplications methods. Thanks!
> 
> I thought some more about refactoring app registration. I propose to:
> - Leave in-process registration as it is because of the differences between
> StaticApplicationMap and OutOfProcessMojoApplicationMap.
> - Define OutOfProcessMojoApplicationMap as std::map<GURL, PROCESS> instead of
> std::map<GURL, PROCESS_NAME>. In the case of utility process, we can derive a
> reasonable PROCESS_NAME from GURL.

How would you derive the PROCESS_NAME from GURL? The process name would be user
facing so we should be careful about it.

> If you guys agree with the proposal, I think it is OK to land this patch as it
> is because it deals with in-process registration only. Thoughts?

landing this CL as is sgtm.

[alokp, 2016-01-26 18:50:34]

alokp@chromium.org changed reviewers:
+ jam@chromium.org

[alokp, 2016-01-26 18:50:34]

+jam for OWNERS stamp

[jam, 2016-01-26 23:33:17]

lgtm

[alokp, 2016-01-26 23:36:35]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-01-26 23:36:35]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1544853003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-01-26 23:37:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1544853003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1544853003/40001

[commit-bot: I haz the power, 2016-01-27 00:40:11]

Description was changed from

==========
Let content embedders register in-process media service.

This change makes the registration of in-process media service consistent with
that of out-of-process service.

BUG=571155
==========

to

==========
Let content embedders register in-process media service.

This change makes the registration of in-process media service consistent with
that of out-of-process service.

BUG=571155
==========

[commit-bot: I haz the power, 2016-01-27 00:40:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-27 00:41:15]

Description was changed from

==========
Let content embedders register in-process media service.

This change makes the registration of in-process media service consistent with
that of out-of-process service.

BUG=571155
==========

to

==========
Let content embedders register in-process media service.

This change makes the registration of in-process media service consistent with
that of out-of-process service.

BUG=571155

Committed: https://crrev.com/6ecb238a745add6bf871e1b7b294696d6daa1f29
Cr-Commit-Position: refs/heads/master@{#371662}
==========

[commit-bot: I haz the power, 2016-01-27 00:41:15]

Patchset 3 (id:??) landed as
https://crrev.com/6ecb238a745add6bf871e1b7b294696d6daa1f29
Cr-Commit-Position: refs/heads/master@{#371662}