Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 1544833002: PPC: [runtime] Rewrite Function.prototype.toString in C++. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Rewrite Function.prototype.toString in C++. Port 4acca53e62cdfe6f3c495c87ca7d3c8fe1059f01 Original commit message: There's actually no point trying to do Function.prototype.toString in JavaScript, as it always calls into C++ at least once, so it only complicates things (esp. once we start optimizing bound functions). Drive-by-fix: Rename FunctionApply and FunctionCall builtins to also reflect the fact that these are builtins in the Function.prototype and not on Function itself. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:535408 LOG=n Committed: https://crrev.com/d95511c57ffb9f61dec8013dfb444c3affa375fe Cr-Commit-Position: refs/heads/master@{#33014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -46 lines) Patch
M src/ppc/builtins-ppc.cc View 2 chunks +47 lines, -46 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
5 years ago (2015-12-22 14:29:52 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544833002/1
5 years ago (2015-12-22 14:39:39 UTC) #3
john.yan
lgtm
5 years ago (2015-12-22 15:08:06 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-22 16:36:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544833002/1
5 years ago (2015-12-22 16:55:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-22 16:57:04 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-22 16:57:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d95511c57ffb9f61dec8013dfb444c3affa375fe
Cr-Commit-Position: refs/heads/master@{#33014}

Powered by Google App Engine
This is Rietveld 408576698