Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4376)

Unified Diff: chrome/browser/ui/views/toolbar/app_menu.cc

Issue 1544803004: Fix accelerator handling for in-menu buttons in the app menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/button/custom_button.h » ('j') | ui/views/controls/button/custom_button.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/app_menu.cc
diff --git a/chrome/browser/ui/views/toolbar/app_menu.cc b/chrome/browser/ui/views/toolbar/app_menu.cc
index cd65d6aebf38a3079cb4d641bd89dffb7b951a05..f99f84aad2205665815ad70039c5b5deecfcbb47 100644
--- a/chrome/browser/ui/views/toolbar/app_menu.cc
+++ b/chrome/browser/ui/views/toolbar/app_menu.cc
@@ -301,6 +301,12 @@ class InMenuButton : public LabelButton {
}
}
+ // views::CustomButton
+ bool ShouldHandleAcceleratorWhenInactive() override {
+ // Menu buttons are inactive, so handle accelerator presses when inactive.
+ return true;
+ }
+
private:
InMenuButtonBackground* in_menu_background_;
« no previous file with comments | « no previous file | ui/views/controls/button/custom_button.h » ('j') | ui/views/controls/button/custom_button.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698