Fix accelerator handling for in-menu buttons in the app menu.

ui/views/view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define _USE_MATH_DEFINES // For VC++ to get M_PI. This has to be first.
 
 #include "ui/views/view.h"
 
 #include <algorithm>
 #include <cmath>
@@ skipping 1128 matching lines @@
 void View::ResetAccelerators() {
   if (accelerators_.get())
     UnregisterAccelerators(false);
 }
 
 bool View::AcceleratorPressed(const ui::Accelerator& accelerator) {
   return false;
 }
 
 bool View::CanHandleAccelerators() const {
-  return enabled() && IsDrawn() && GetWidget() && GetWidget()->IsVisible();
+  const Widget* widget = GetWidget();
+  if (!enabled() || !IsDrawn() || !widget || !widget->IsVisible()) {

[msw, 2016/02/04 22:45:36]

nit: curlies not needed

[meacer, 2016/02/09 20:33:32]

Done.

+    return false;
+  }
+#if defined(USE_AURA)
+  // Aura windows have an associated FocusManagerEventHandler which adds
+  // currently focused view as an event PreTarget. However, the focused view
+  // isn't always the right view to handle accelerators: It should only
+  // handle them when active. Only top level widgets can be active, so
+  // for child widgets check if they are focused instead.
+  bool child = GetWidget() && GetWidget()->GetTopLevelWidget() != GetWidget();

[msw, 2016/02/04 22:45:36]

nit: re-use |widget| here and below.

[meacer, 2016/02/09 20:33:32]

Done.

+  bool focus_in_child =
+      GetWidget() &&
+      GetWidget()->GetRootView()->Contains(GetFocusManager()->GetFocusedView());
+  if ((child && !focus_in_child) || (!child && !widget->IsActive())) {

[msw, 2016/02/04 22:45:36]

nit: curlies not needed

[meacer, 2016/02/09 20:33:32]

Done.

+    return false;
+  }
+#endif
+  return true;
 }
 
 // Focus -----------------------------------------------------------------------
 
 bool View::HasFocus() const {
   const FocusManager* focus_manager = GetFocusManager();
   return focus_manager && (focus_manager->GetFocusedView() == this);
 }
 
 View* View::GetNextFocusableView() {
@@ skipping 1244 matching lines @@
   // Message the RootView to do the drag and drop. That way if we're removed
   // the RootView can detect it and avoid calling us back.
   gfx::Point widget_location(event.location());
   ConvertPointToWidget(this, &widget_location);
   widget->RunShellDrag(this, data, widget_location, drag_operations, source);
   // WARNING: we may have been deleted.
   return true;
 }
 
 }  // namespace views