Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1544803003: GN: Set --coverage-dir in bin/run_* script when emma_coverage = true (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Set --coverage-dir in bin/run_* script when emma_coverage = true BUG= Committed: https://crrev.com/9dff782b5cef8d48a5a89b352a0576aa1074ba83 Cr-Commit-Position: refs/heads/master@{#366674}

Patch Set 1 #

Patch Set 2 : add gypi support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M build/android/gyp/create_test_runner_script.py View 2 chunks +4 lines, -0 lines 0 comments Download
M build/android/test_runner.gypi View 1 1 chunk +7 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
agrieve
On 2015/12/22 19:49:57, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org 🎅
5 years ago (2015-12-22 19:50:05 UTC) #3
jbudorick
there should be an equivalent change to build/android/test_runner.gypi
5 years ago (2015-12-22 19:52:20 UTC) #4
agrieve
On 2015/12/22 19:52:20, jbudorick wrote: > there should be an equivalent change to build/android/test_runner.gypi done
5 years ago (2015-12-22 21:22:21 UTC) #5
jbudorick
lgtm
5 years ago (2015-12-22 21:23:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544803003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544803003/20001
5 years ago (2015-12-22 21:30:29 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-22 22:40:57 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-22 22:41:39 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9dff782b5cef8d48a5a89b352a0576aa1074ba83
Cr-Commit-Position: refs/heads/master@{#366674}

Powered by Google App Engine
This is Rietveld 408576698