Android / Telemetry: use android-chromium-testshell instead of content-shell.

Android / Telemetry: use android-chromium-testshell instead of content-shell.

Follow up on https://codereview.chromium.org/15115005/
Install ChromiumTestShell instead of ContentShell

BUG=237057
R=ilevy@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207779

[bulach, 2013-05-20 08:01:40]

this is required by https://codereview.chromium.org/15291003/ , bad news it's in
a different repo.. :-/ ptal

[tonyg, 2013-05-20 16:26:17]

https://codereview.chromium.org/15448002/diff/1/build/android/buildbot/bb_run...
File build/android/buildbot/bb_run_bot.py (right):

https://codereview.chromium.org/15448002/diff/1/build/android/buildbot/bb_run...
build/android/buildbot/bb_run_bot.py:118: T([],
['--install=ChromiumTestShell']),
Ilevy should review, but I'm not sure whether this is the right change. I'm
looking at the step here:
http://build.chromium.org/p/chromium.perf/builders/Android%20GN/builds/7234/s...

And I'm not sure what controls the step name "install_contentshell" and the
"--apk_package org.chromium.content_shell_apk" argument.

[bulach, 2013-05-21 07:45:46]

https://codereview.chromium.org/15448002/diff/1/build/android/buildbot/bb_run...
File build/android/buildbot/bb_run_bot.py (right):

https://codereview.chromium.org/15448002/diff/1/build/android/buildbot/bb_run...
build/android/buildbot/bb_run_bot.py:118: T([],
['--install=ChromiumTestShell']),
On 2013/05/20 16:26:17, tonyg wrote:
> Ilevy should review, but I'm not sure whether this is the right change. I'm
> looking at the step here:
>
http://build.chromium.org/p/chromium.perf/builders/Android%2520GN/builds/7234...
> 
> And I'm not sure what controls the step name "install_contentshell" and the
> "--apk_package org.chromium.content_shell_apk" argument.

yeah, I'm not sure either, there are so. many. layers... :)

afaict, this eventually calls into:
http://src.chromium.org/viewvc/chrome/trunk/src/build/android/buildbot/bb_dev...

and InstallApk(), which prints the step name and installs the APK..

I'll wait for ilevy's confirmation though, and then we'll need to coordinate
when to land this, the bot side and restart chromium.perf master...

[Isaac (away), 2013-06-08 07:28:16]

Are you still waiting on this?

[bulach, 2013-06-10 17:37:21]

yes, sorry, it went under my radar...

we want to move all perf tests to chromium test shell instead of content shell..
please see previous question, no idea if this is the right place.

[Isaac (away), 2013-06-15 07:35:02]

lgtm

https://codereview.chromium.org/15448002/diff/1/build/android/buildbot/bb_run...
File build/android/buildbot/bb_run_bot.py (right):

https://codereview.chromium.org/15448002/diff/1/build/android/buildbot/bb_run...
build/android/buildbot/bb_run_bot.py:118: T([],
['--install=ChromiumTestShell']),
On 2013/05/21 07:45:46, bulach wrote:
> On 2013/05/20 16:26:17, tonyg wrote:
> > Ilevy should review, but I'm not sure whether this is the right change. I'm
> > looking at the step here:
> >
>
http://build.chromium.org/p/chromium.perf/builders/Android%252520GN/builds/72...
> > 
> > And I'm not sure what controls the step name "install_contentshell" and the
> > "--apk_package org.chromium.content_shell_apk" argument.
> 
> yeah, I'm not sure either, there are so. many. layers... :)
> 
> afaict, this eventually calls into:
>
http://src.chromium.org/viewvc/chrome/trunk/src/build/android/buildbot/bb_dev...
> 
> and InstallApk(), which prints the step name and installs the APK..
> 
> I'll wait for ilevy's confirmation though, and then we'll need to coordinate
> when to land this, the bot side and restart chromium.perf master...

Yes, this is correct.

[Isaac (away), 2013-06-15 07:37:56]

Also:
- this code has changed -- it will probably be easiest to make the change again
from tip of tree
- what do you need the master restart for?
- You can try:

./bb_run_bot --testing --bot-id perf-tests-rel

to get a list of commands, and then run the install_apk one to see what happens.

[bulach, 2013-06-17 11:39:56]

thanks isaac! rebased, and tested as you suggested, seems to be fine.

I also added you to the buildbot side: https://codereview.chromium.org/15291003/

I suppose since it's in the slave/ directory it doesn't require any restart and
the slaves will automatically pick them up?

[Isaac (away), 2013-06-17 22:58:12]

Yes, this is correct -- the build/ repo CL will take affect as soon as you
submit.

[bulach, 2013-06-18 13:56:53]

thanks isaac! the best way is to submit them both together, then? if so, I'll do
this tomorrow LON morning, with a quieter tree..

[Isaac (away), 2013-06-18 18:05:22]

Yeah that sounds good.

[bulach, 2013-06-21 10:01:28]

Committed patchset #2 manually as r207779 (presubmit successful).