Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 1544793002: [tests] Fix bogus uses of assertThrows. (Closed)

Created:
5 years ago by neis
Modified:
4 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tests] Fix bogus uses of assertThrows. Some tests passed a string as second argument to assertThrows, expecting it to be matched against the exception. However, assertThrows simply ignored these. (Some other tests actually seem to use that argument as a comment ...) This CL - changes assertThrows to fail if the second argument is not a function, - adds assertThrowsEquals which compares the exception to a given value using assertEquals - fixes some bogus tests that got exposed by this. R=jarin@chromium.org BUG= Committed: https://crrev.com/837900ef24dcfaa94fcd6cb3ae00c69f717f4e21 Cr-Commit-Position: refs/heads/master@{#33159}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -194 lines) Patch
M test/mjsunit/asm/infinite-loops-taken.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/d8-os.js View 4 chunks +11 lines, -11 lines 0 comments Download
M test/mjsunit/es6/array-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/object-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/proxies.js View 22 chunks +63 lines, -112 lines 0 comments Download
M test/mjsunit/harmony/proxies-for.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/proxies-with.js View 4 chunks +6 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/reflect.js View 6 chunks +6 lines, -7 lines 0 comments Download
M test/mjsunit/mjsunit.js View 3 chunks +17 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-70066.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/third_party/regexp-pcre/regexp-pcre.js View 16 chunks +51 lines, -51 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
neis
5 years ago (2015-12-22 11:26:16 UTC) #1
Jarin
lgtm
4 years, 11 months ago (2016-01-04 07:42:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544793002/20001
4 years, 11 months ago (2016-01-07 14:25:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-07 14:49:01 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 14:49:27 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/837900ef24dcfaa94fcd6cb3ae00c69f717f4e21
Cr-Commit-Position: refs/heads/master@{#33159}

Powered by Google App Engine
This is Rietveld 408576698