Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 1544783002: Disable map in Work Chrome (Closed)

Created:
5 years ago by vichang1
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable mmap in sqlite for Work Chrome build BUG=554269 Committed: https://crrev.com/3ab540e9295d58cef97cc56533498420abb4a3ff Cr-Commit-Position: refs/heads/master@{#367054}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M third_party/sqlite/BUILD.gn View 1 2 2 chunks +14 lines, -7 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 2 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
vichang1
5 years ago (2015-12-22 11:15:44 UTC) #2
Scott Hess - ex-Googler
LGTM
4 years, 12 months ago (2015-12-27 00:09:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544783002/40001
4 years, 11 months ago (2015-12-29 04:42:29 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2015-12-29 05:40:28 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3ab540e9295d58cef97cc56533498420abb4a3ff Cr-Commit-Position: refs/heads/master@{#367054}
4 years, 11 months ago (2015-12-29 05:41:09 UTC) #13
vichang1
4 years, 11 months ago (2016-01-11 17:48:51 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1578813002/ by vichang@chromium.org.

The reason for reverting is: Revert this CL to fix crbug.com/575092..

Powered by Google App Engine
This is Rietveld 408576698