Revert of [Download] Treat RESUMING_INTERNAL as IN_PROGRESS in DownloadItem.

Revert of [Download] Treat RESUMING_INTERNAL as IN_PROGRESS in DownloadItem. (patchset #2 id:20001 of https://codereview.chromium.org/1544653002/ )

Reason for revert:
DownloadTest.Resumption_Automatic began failing in browser_tests
on Windows-XP-SP3 after this patch landed. See:

https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/42034

Reverting to see if we can green the chromium tree.

Original issue's description:
> [Download] Treat RESUMING_INTERNAL as IN_PROGRESS in DownloadItem.
>
> The RESUMING_INTERNAL state is used to indicate that the DownloadItem
> has commenced a resumption attempt. The DownloadItem will remain in this
> state until the network request receives a response.
>
> Formerly, we treated this internal state as INTERRUPTED for all entities
> that are observing the download item, including the UI. However, in
> retrospect, this doesn't make sense and prevents the DownloadItem from
> cleanly handling cases where it needs to transition back to an
> interrupted state following a resumption attempt. In the latter case,
> the download would otherwise try to transition from INTERRUPTED ->
> INTERRUPTED which doesn't make a whole lot of sense to an outside
> observer.
>
> In addition, keeping the download in the INTERRUPTED state prevents an
> outside observer from being able to cleanly tell when a resumption
> attempt has begun. Furthermore, the INTERRUPTED state exhibited while an
> automatic resumption is being attempted is not actionable to all outside
> observers.
>
> To rectify these, this change makes the RESUMING_INTERNAL state be
> visible to external observers as IN_PROGRESS.
>
> BUG=7648
> R=svaldez@chromium.org
>
> Committed: https://crrev.com/ad29c15e3115a256cec6ee0ab0ba3138ef087569
> Cr-Commit-Position: refs/heads/master@{#366542}

TBR=svaldez@chromium.org,asanka@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=7648
Committed: https://crrev.com/5a45da8d4a87ffc6100ab8b684f3ad2eaef639b4
Cr-Commit-Position: refs/heads/master@{#366574}

[Noel Gordon, 2015-12-22 09:25:18]

Created Revert of [Download] Treat RESUMING_INTERNAL as IN_PROGRESS in
DownloadItem.

[commit-bot: I haz the power, 2015-12-22 09:25:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1544743003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1544743003/1

[commit-bot: I haz the power, 2015-12-22 09:26:07]

Description was changed from

==========
Revert of [Download] Treat RESUMING_INTERNAL as IN_PROGRESS in DownloadItem.
(patchset #2 id:20001 of https://codereview.chromium.org/1544653002/ )

Reason for revert:
DownloadTest.Resumption_Automatic began failing in browser_tests
on Windows-XP-SP3 after this patch landed. See:

https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/build...

Reverting to see if we can green the chromium tree.



Original issue's description:
> [Download] Treat RESUMING_INTERNAL as IN_PROGRESS in DownloadItem.
> 
> The RESUMING_INTERNAL state is used to indicate that the DownloadItem
> has commenced a resumption attempt. The DownloadItem will remain in this
> state until the network request receives a response.
> 
> Formerly, we treated this internal state as INTERRUPTED for all entities
> that are observing the download item, including the UI. However, in
> retrospect, this doesn't make sense and prevents the DownloadItem from
> cleanly handling cases where it needs to transition back to an
> interrupted state following a resumption attempt. In the latter case,
> the download would otherwise try to transition from INTERRUPTED ->
> INTERRUPTED which doesn't make a whole lot of sense to an outside
> observer.
> 
> In addition, keeping the download in the INTERRUPTED state prevents an
> outside observer from being able to cleanly tell when a resumption
> attempt has begun. Furthermore, the INTERRUPTED state exhibited while an
> automatic resumption is being attempted is not actionable to all outside
> observers.
> 
> To rectify these, this change makes the RESUMING_INTERNAL state be
> visible to external observers as IN_PROGRESS.
> 
> BUG=7648
> R=svaldez@chromium.org
> 
> Committed: https://crrev.com/ad29c15e3115a256cec6ee0ab0ba3138ef087569
> Cr-Commit-Position: refs/heads/master@{#366542}

TBR=svaldez@chromium.org,asanka@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=7648
==========

to

==========
Revert of [Download] Treat RESUMING_INTERNAL as IN_PROGRESS in DownloadItem.
(patchset #2 id:20001 of https://codereview.chromium.org/1544653002/ )

Reason for revert:
DownloadTest.Resumption_Automatic began failing in browser_tests
on Windows-XP-SP3 after this patch landed. See:

https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/build...

Reverting to see if we can green the chromium tree.



Original issue's description:
> [Download] Treat RESUMING_INTERNAL as IN_PROGRESS in DownloadItem.
> 
> The RESUMING_INTERNAL state is used to indicate that the DownloadItem
> has commenced a resumption attempt. The DownloadItem will remain in this
> state until the network request receives a response.
> 
> Formerly, we treated this internal state as INTERRUPTED for all entities
> that are observing the download item, including the UI. However, in
> retrospect, this doesn't make sense and prevents the DownloadItem from
> cleanly handling cases where it needs to transition back to an
> interrupted state following a resumption attempt. In the latter case,
> the download would otherwise try to transition from INTERRUPTED ->
> INTERRUPTED which doesn't make a whole lot of sense to an outside
> observer.
> 
> In addition, keeping the download in the INTERRUPTED state prevents an
> outside observer from being able to cleanly tell when a resumption
> attempt has begun. Furthermore, the INTERRUPTED state exhibited while an
> automatic resumption is being attempted is not actionable to all outside
> observers.
> 
> To rectify these, this change makes the RESUMING_INTERNAL state be
> visible to external observers as IN_PROGRESS.
> 
> BUG=7648
> R=svaldez@chromium.org
> 
> Committed: https://crrev.com/ad29c15e3115a256cec6ee0ab0ba3138ef087569
> Cr-Commit-Position: refs/heads/master@{#366542}

TBR=svaldez@chromium.org,asanka@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=7648
==========

[commit-bot: I haz the power, 2015-12-22 09:26:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-22 09:27:01]

Description was changed from

==========
Revert of [Download] Treat RESUMING_INTERNAL as IN_PROGRESS in DownloadItem.
(patchset #2 id:20001 of https://codereview.chromium.org/1544653002/ )

Reason for revert:
DownloadTest.Resumption_Automatic began failing in browser_tests
on Windows-XP-SP3 after this patch landed. See:

https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/build...

Reverting to see if we can green the chromium tree.



Original issue's description:
> [Download] Treat RESUMING_INTERNAL as IN_PROGRESS in DownloadItem.
> 
> The RESUMING_INTERNAL state is used to indicate that the DownloadItem
> has commenced a resumption attempt. The DownloadItem will remain in this
> state until the network request receives a response.
> 
> Formerly, we treated this internal state as INTERRUPTED for all entities
> that are observing the download item, including the UI. However, in
> retrospect, this doesn't make sense and prevents the DownloadItem from
> cleanly handling cases where it needs to transition back to an
> interrupted state following a resumption attempt. In the latter case,
> the download would otherwise try to transition from INTERRUPTED ->
> INTERRUPTED which doesn't make a whole lot of sense to an outside
> observer.
> 
> In addition, keeping the download in the INTERRUPTED state prevents an
> outside observer from being able to cleanly tell when a resumption
> attempt has begun. Furthermore, the INTERRUPTED state exhibited while an
> automatic resumption is being attempted is not actionable to all outside
> observers.
> 
> To rectify these, this change makes the RESUMING_INTERNAL state be
> visible to external observers as IN_PROGRESS.
> 
> BUG=7648
> R=svaldez@chromium.org
> 
> Committed: https://crrev.com/ad29c15e3115a256cec6ee0ab0ba3138ef087569
> Cr-Commit-Position: refs/heads/master@{#366542}

TBR=svaldez@chromium.org,asanka@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=7648
==========

to

==========
Revert of [Download] Treat RESUMING_INTERNAL as IN_PROGRESS in DownloadItem.
(patchset #2 id:20001 of https://codereview.chromium.org/1544653002/ )

Reason for revert:
DownloadTest.Resumption_Automatic began failing in browser_tests
on Windows-XP-SP3 after this patch landed. See:

https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/build...

Reverting to see if we can green the chromium tree.

Original issue's description:
> [Download] Treat RESUMING_INTERNAL as IN_PROGRESS in DownloadItem.
>
> The RESUMING_INTERNAL state is used to indicate that the DownloadItem
> has commenced a resumption attempt. The DownloadItem will remain in this
> state until the network request receives a response.
>
> Formerly, we treated this internal state as INTERRUPTED for all entities
> that are observing the download item, including the UI. However, in
> retrospect, this doesn't make sense and prevents the DownloadItem from
> cleanly handling cases where it needs to transition back to an
> interrupted state following a resumption attempt. In the latter case,
> the download would otherwise try to transition from INTERRUPTED ->
> INTERRUPTED which doesn't make a whole lot of sense to an outside
> observer.
>
> In addition, keeping the download in the INTERRUPTED state prevents an
> outside observer from being able to cleanly tell when a resumption
> attempt has begun. Furthermore, the INTERRUPTED state exhibited while an
> automatic resumption is being attempted is not actionable to all outside
> observers.
>
> To rectify these, this change makes the RESUMING_INTERNAL state be
> visible to external observers as IN_PROGRESS.
>
> BUG=7648
> R=svaldez@chromium.org
>
> Committed: https://crrev.com/ad29c15e3115a256cec6ee0ab0ba3138ef087569
> Cr-Commit-Position: refs/heads/master@{#366542}

TBR=svaldez@chromium.org,asanka@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=7648

Committed: https://crrev.com/5a45da8d4a87ffc6100ab8b684f3ad2eaef639b4
Cr-Commit-Position: refs/heads/master@{#366574}
==========

[commit-bot: I haz the power, 2015-12-22 09:27:01]

Patchset 1 (id:??) landed as
https://crrev.com/5a45da8d4a87ffc6100ab8b684f3ad2eaef639b4
Cr-Commit-Position: refs/heads/master@{#366574}

[Noel Gordon, 2015-12-22 12:13:36]

Next build after this patch landed went green:
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/build...