chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc - Issue 154473002: Support redirectUrl at onHeadersReceived in WebRequest / DWR API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc

Issue 154473002: Support redirectUrl at onHeadersReceived in WebRequest / DWR API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix WebRequestRulesRegistrySimpleTest.StageChecker test Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/net/aw_network_delegate.cc ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc

index 8731d288dabb9008adb679e9a4255481cccf65a3..739d0744b955c08569db4a8f5bf9f501b75c6541 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc

@@ -582,7 +582,7 @@ LinkedPtrEventResponseDelta WebRequestCancelAction::CreateDelta(

WebRequestRedirectAction::WebRequestRedirectAction(const GURL& redirect_url)

- : WebRequestAction(ON_BEFORE_REQUEST,

+ : WebRequestAction(ON_BEFORE_REQUEST | ON_HEADERS_RECEIVED,

ACTION_REDIRECT_REQUEST,

std::numeric_limits<int>::min(),

STRATEGY_DEFAULT),

@@ -619,7 +619,7 @@ LinkedPtrEventResponseDelta WebRequestRedirectAction::CreateDelta(

WebRequestRedirectToTransparentImageAction::

WebRequestRedirectToTransparentImageAction()

- : WebRequestAction(ON_BEFORE_REQUEST,

+ : WebRequestAction(ON_BEFORE_REQUEST | ON_HEADERS_RECEIVED,

ACTION_REDIRECT_TO_TRANSPARENT_IMAGE,

std::numeric_limits<int>::min(),

STRATEGY_NONE) {}

@@ -649,7 +649,7 @@ WebRequestRedirectToTransparentImageAction::CreateDelta(

WebRequestRedirectToEmptyDocumentAction::

WebRequestRedirectToEmptyDocumentAction()

- : WebRequestAction(ON_BEFORE_REQUEST,

+ : WebRequestAction(ON_BEFORE_REQUEST | ON_HEADERS_RECEIVED,

ACTION_REDIRECT_TO_EMPTY_DOCUMENT,

std::numeric_limits<int>::min(),

STRATEGY_NONE) {}

@@ -680,7 +680,7 @@ WebRequestRedirectToEmptyDocumentAction::CreateDelta(

WebRequestRedirectByRegExAction::WebRequestRedirectByRegExAction(

scoped_ptr<RE2> from_pattern,

const std::string& to_pattern)

- : WebRequestAction(ON_BEFORE_REQUEST,

+ : WebRequestAction(ON_BEFORE_REQUEST | ON_HEADERS_RECEIVED,

ACTION_REDIRECT_BY_REGEX_DOCUMENT,

std::numeric_limits<int>::min(),

STRATEGY_DEFAULT),