| Index: chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
|
| diff --git a/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc b/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
|
| index 4156f98c3712ceb6dfa2fa7ea3a1448b80a324a9..926db393ab669bc7518dcd0a6d03f9186b85a888 100644
|
| --- a/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
|
| +++ b/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
|
| @@ -323,11 +323,13 @@ EventResponseDelta* CalculateOnHeadersReceivedDelta(
|
| const std::string& extension_id,
|
| const base::Time& extension_install_time,
|
| bool cancel,
|
| + const GURL& new_url,
|
| const net::HttpResponseHeaders* old_response_headers,
|
| ResponseHeaders* new_response_headers) {
|
| EventResponseDelta* result =
|
| new EventResponseDelta(extension_id, extension_install_time);
|
| result->cancel = cancel;
|
| + result->new_url = new_url;
|
|
|
| if (!new_response_headers)
|
| return result;
|
| @@ -402,14 +404,14 @@ void MergeCancelOfResponses(
|
| }
|
| }
|
|
|
| -// Helper function for MergeOnBeforeRequestResponses() that allows ignoring
|
| +// Helper function for MergeRedirectUrlOfResponses() that allows ignoring
|
| // all redirects but those to data:// urls and about:blank. This is important
|
| // to treat these URLs as "cancel urls", i.e. URLs that extensions redirect
|
| // to if they want to express that they want to cancel a request. This reduces
|
| // the number of conflicts that we need to flag, as canceling is considered
|
| // a higher precedence operation that redirects.
|
| // Returns whether a redirect occurred.
|
| -static bool MergeOnBeforeRequestResponsesHelper(
|
| +static bool MergeRedirectUrlOfResponsesHelper(
|
| const EventResponseDeltas& deltas,
|
| GURL* new_url,
|
| extensions::ExtensionWarningSet* conflicting_extensions,
|
| @@ -451,7 +453,7 @@ static bool MergeOnBeforeRequestResponsesHelper(
|
| return redirected;
|
| }
|
|
|
| -void MergeOnBeforeRequestResponses(
|
| +void MergeRedirectUrlOfResponses(
|
| const EventResponseDeltas& deltas,
|
| GURL* new_url,
|
| extensions::ExtensionWarningSet* conflicting_extensions,
|
| @@ -459,7 +461,7 @@ void MergeOnBeforeRequestResponses(
|
|
|
| // First handle only redirects to data:// URLs and about:blank. These are a
|
| // special case as they represent a way of cancelling a request.
|
| - if (MergeOnBeforeRequestResponsesHelper(
|
| + if (MergeRedirectUrlOfResponsesHelper(
|
| deltas, new_url, conflicting_extensions, net_log, true)) {
|
| // If any extension cancelled a request by redirecting to a data:// URL or
|
| // about:blank, we don't consider the other redirects.
|
| @@ -467,10 +469,18 @@ void MergeOnBeforeRequestResponses(
|
| }
|
|
|
| // Handle all other redirects.
|
| - MergeOnBeforeRequestResponsesHelper(
|
| + MergeRedirectUrlOfResponsesHelper(
|
| deltas, new_url, conflicting_extensions, net_log, false);
|
| }
|
|
|
| +void MergeOnBeforeRequestResponses(
|
| + const EventResponseDeltas& deltas,
|
| + GURL* new_url,
|
| + extensions::ExtensionWarningSet* conflicting_extensions,
|
| + const net::BoundNetLog* net_log) {
|
| + MergeRedirectUrlOfResponses(deltas, new_url, conflicting_extensions, net_log);
|
| +}
|
| +
|
| // Assumes that |header_value| is the cookie header value of a HTTP Request
|
| // following the cookie-string schema of RFC 6265, section 4.2.1, and returns
|
| // cookie name/value pairs. If cookie values are presented in double quotes,
|
| @@ -1097,6 +1107,7 @@ static std::string FindRemoveResponseHeader(
|
|
|
| void MergeOnHeadersReceivedResponses(
|
| const EventResponseDeltas& deltas,
|
| + GURL* new_url,
|
| const net::HttpResponseHeaders* original_response_headers,
|
| scoped_refptr<net::HttpResponseHeaders>* override_response_headers,
|
| extensions::ExtensionWarningSet* conflicting_extensions,
|
| @@ -1180,6 +1191,8 @@ void MergeOnHeadersReceivedResponses(
|
|
|
| MergeCookiesInOnHeadersReceivedResponses(deltas, original_response_headers,
|
| override_response_headers, conflicting_extensions, net_log);
|
| +
|
| + MergeRedirectUrlOfResponses(deltas, new_url, conflicting_extensions, net_log);
|
| }
|
|
|
| bool MergeOnAuthRequiredResponses(
|
|
|