Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1544703002: Ignore constructor phase parameter (Closed)

Created:
5 years ago by hausner
Modified:
5 years ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ignore constructor phase parameter When --move_super is true (the default value), the super constructor call is moved to the end of the initializer list. In that case, the phase parameter is not necessary. This change eliminates the check of the phase parameter in the constructor code, but does not yet eliminate the phase parameter. BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/cb5e5868486759e8d4d53627dbd9a59b120ec666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M runtime/vm/parser.cc View 2 chunks +27 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hausner
5 years ago (2015-12-21 22:45:31 UTC) #3
srdjan
lgtm
5 years ago (2015-12-21 22:49:40 UTC) #4
hausner
Committed patchset #1 (id:1) manually as cb5e5868486759e8d4d53627dbd9a59b120ec666 (presubmit successful).
5 years ago (2015-12-21 23:01:17 UTC) #6
hausner
5 years ago (2015-12-21 23:01:36 UTC) #7
Message was sent while issue was closed.
Thank you.

Powered by Google App Engine
This is Rietveld 408576698