Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: third_party/WebKit/Source/core/svg/SVGRect.h

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGRect.h
diff --git a/third_party/WebKit/Source/core/svg/SVGRect.h b/third_party/WebKit/Source/core/svg/SVGRect.h
index 88d9c7743a16a209ab23b0e32aaa3e77a84ddaa8..bee8df8fe578b4c1d8deb1149a9d9b6017581162 100644
--- a/third_party/WebKit/Source/core/svg/SVGRect.h
+++ b/third_party/WebKit/Source/core/svg/SVGRect.h
@@ -20,6 +20,7 @@
#ifndef SVGRect_h
#define SVGRect_h
+#include "core/svg/SVGParsingError.h"
#include "core/svg/properties/SVGPropertyHelper.h"
#include "platform/geometry/FloatRect.h"
#include "wtf/Allocator.h"
@@ -64,7 +65,7 @@ public:
void setHeight(float f) { m_value.setHeight(f); }
String valueAsString() const override;
- void setValueAsString(const String&, ExceptionState&);
+ SVGParsingError setValueAsString(const String&);
void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;
void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawPtr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDurationValue, SVGElement* contextElement) override;
@@ -80,7 +81,7 @@ private:
SVGRect(const FloatRect&);
template<typename CharType>
- void parse(const CharType*& ptr, const CharType* end, ExceptionState&);
+ bool parse(const CharType*& ptr, const CharType* end);
bool m_isValid;
FloatRect m_value;

Powered by Google App Engine
This is Rietveld 408576698