Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGPointList.h

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef SVGPointList_h 31 #ifndef SVGPointList_h
32 #define SVGPointList_h 32 #define SVGPointList_h
33 33
34 #include "bindings/core/v8/ScriptWrappable.h" 34 #include "core/svg/SVGParsingError.h"
35 #include "core/svg/SVGPoint.h" 35 #include "core/svg/SVGPoint.h"
36 #include "core/svg/properties/SVGListPropertyHelper.h" 36 #include "core/svg/properties/SVGListPropertyHelper.h"
37 37
38 namespace blink { 38 namespace blink {
39 39
40 class SVGPointListTearOff; 40 class SVGPointListTearOff;
41 41
42 class SVGPointList final : public SVGListPropertyHelper<SVGPointList, SVGPoint> { 42 class SVGPointList final : public SVGListPropertyHelper<SVGPointList, SVGPoint> {
43 public: 43 public:
44 typedef SVGPointListTearOff TearOffType; 44 typedef SVGPointListTearOff TearOffType;
45 45
46 static PassRefPtrWillBeRawPtr<SVGPointList> create() 46 static PassRefPtrWillBeRawPtr<SVGPointList> create()
47 { 47 {
48 return adoptRefWillBeNoop(new SVGPointList()); 48 return adoptRefWillBeNoop(new SVGPointList());
49 } 49 }
50 50
51 ~SVGPointList() override; 51 ~SVGPointList() override;
52 52
53 void setValueAsString(const String&, ExceptionState&); 53 SVGParsingError setValueAsString(const String&);
54 54
55 // SVGPropertyBase: 55 // SVGPropertyBase:
56 String valueAsString() const override; 56 String valueAsString() const override;
57 57
58 void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override; 58 void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;
59 void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> fromValue, PassRefPtrWillB eRawPtr<SVGPropertyBase> toValue, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEn dOfDurationValue, SVGElement*) override; 59 void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> fromValue, PassRefPtrWillB eRawPtr<SVGPropertyBase> toValue, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEn dOfDurationValue, SVGElement*) override;
60 float calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> to, SVGEleme nt*) override; 60 float calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> to, SVGEleme nt*) override;
61 61
62 static AnimatedPropertyType classType() { return AnimatedPoints; } 62 static AnimatedPropertyType classType() { return AnimatedPoints; }
63 63
64 private: 64 private:
65 SVGPointList(); 65 SVGPointList();
66 66
67 template <typename CharType> 67 template <typename CharType>
68 bool parse(const CharType*& ptr, const CharType* end); 68 bool parse(const CharType*& ptr, const CharType* end);
69 }; 69 };
70 70
71 DEFINE_SVG_PROPERTY_TYPE_CASTS(SVGPointList); 71 DEFINE_SVG_PROPERTY_TYPE_CASTS(SVGPointList);
72 72
73 } // namespace blink 73 } // namespace blink
74 74
75 #endif // SVGPointList_h 75 #endif // SVGPointList_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698