Refactor propagation of parsing errors for SVG attributes

third_party/WebKit/Source/core/svg/SVGPathElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 18 matching lines @@
 
 namespace blink {
 
 class SVGAnimatedPathLength final : public SVGAnimatedNumber {
 public:
     static PassRefPtrWillBeRawPtr<SVGAnimatedPathLength> create(SVGPathElement* contextElement)
     {
         return adoptRefWillBeNoop(new SVGAnimatedPathLength(contextElement));
     }
 
-    void setBaseValueAsString(const String& value, SVGParsingError& parseError) override
+    SVGParsingError setBaseValueAsString(const String& value) override
     {
-        SVGAnimatedNumber::setBaseValueAsString(value, parseError);
+        SVGParsingError parseStatus = SVGAnimatedNumber::setBaseValueAsString(value);
 
         ASSERT(contextElement());
-        if (parseError == NoError && baseValue()->value() < 0)
+        if (parseStatus == NoError && baseValue()->value() < 0)
             contextElement()->document().accessSVGExtensions().reportError("A negative value for path attribute <pathLength> is not allowed");
+        return parseStatus;
     }
 
 private:
     explicit SVGAnimatedPathLength(SVGPathElement* contextElement)
         : SVGAnimatedNumber(contextElement, SVGNames::pathLengthAttr, SVGNumber::create())
     {
     }
 };
 
 inline SVGPathElement::SVGPathElement(Document& document)
@@ skipping 123 matching lines @@
     return InsertionDone;
 }
 
 void SVGPathElement::removedFrom(ContainerNode* rootParent)
 {
     SVGGeometryElement::removedFrom(rootParent);
     invalidateMPathDependencies();
 }
 
 } // namespace blink