Refactor propagation of parsing errors for SVG attributes

third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp

 /*
  * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2010 Rob Buis <buis@kde.org>
  * Copyright (C) 2014 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 20 matching lines @@
 
 namespace blink {
 
 class SVGAnimatedViewBoxRect : public SVGAnimatedRect {
 public:
     static PassRefPtrWillBeRawPtr<SVGAnimatedRect> create(SVGElement* contextElement)
     {
         return adoptRefWillBeNoop(new SVGAnimatedViewBoxRect(contextElement));
     }
 
-    void setBaseValueAsString(const String&, SVGParsingError&) override;
+    SVGParsingError setBaseValueAsString(const String&) override;
 
 protected:
     SVGAnimatedViewBoxRect(SVGElement* contextElement)
         : SVGAnimatedRect(contextElement, SVGNames::viewBoxAttr)
     {
     }
 };
 
-void SVGAnimatedViewBoxRect::setBaseValueAsString(const String& value, SVGParsingError& parseError)
+SVGParsingError SVGAnimatedViewBoxRect::setBaseValueAsString(const String& value)
 {
-    TrackExceptionState es;
+    SVGParsingError parseStatus = baseValue()->setValueAsString(value);
 
-    baseValue()->setValueAsString(value, es);
-
-    if (es.hadException()) {
-        parseError = ParsingAttributeFailedError;
-        return;
-    }
-
-    if (baseValue()->width() < 0 || baseValue()->height() < 0) {
-        parseError = NegativeValueForbiddenError;
+    if (parseStatus == NoError && (baseValue()->width() < 0 || baseValue()->height() < 0)) {
+        parseStatus = NegativeValueForbiddenError;
         baseValue()->setInvalid();
     }
+    return parseStatus;
 }
 
 SVGFitToViewBox::SVGFitToViewBox(SVGElement* element, PropertyMapPolicy propertyMapPolicy)
     : m_viewBox(SVGAnimatedViewBoxRect::create(element))
     , m_preserveAspectRatio(SVGAnimatedPreserveAspectRatio::create(element, SVGNames::preserveAspectRatioAttr, SVGPreserveAspectRatio::create()))
 {
     ASSERT(element);
     if (propertyMapPolicy == PropertyMapPolicyAdd) {
         element->addToPropertyMap(m_viewBox);
         element->addToPropertyMap(m_preserveAspectRatio);
@@ skipping 19 matching lines @@
     return attrName == SVGNames::viewBoxAttr || attrName == SVGNames::preserveAspectRatioAttr;
 }
 
 void SVGFitToViewBox::updateViewBox(const FloatRect& rect)
 {
     ASSERT(m_viewBox);
     m_viewBox->baseValue()->setValue(rect);
 }
 
 }