Refactor propagation of parsing errors for SVG attributes

third_party/WebKit/Source/core/svg/SVGEnumeration.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 12 matching lines @@
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/svg/SVGEnumeration.h"
 
-#include "bindings/core/v8/ExceptionState.h"
-#include "bindings/core/v8/ExceptionStatePlaceholder.h"
-#include "core/dom/ExceptionCode.h"
 #include "core/svg/SVGAnimationElement.h"
 
 namespace blink {
 
 DEFINE_SVG_PROPERTY_TYPE_CASTS(SVGEnumerationBase);
 
 SVGEnumerationBase::~SVGEnumerationBase()
 {
 }
 
 PassRefPtrWillBeRawPtr<SVGPropertyBase> SVGEnumerationBase::cloneForAnimation(const String& value) const
 {
     RefPtrWillBeRawPtr<SVGEnumerationBase> svgEnumeration = clone();
-    svgEnumeration->setValueAsString(value, IGNORE_EXCEPTION);
+    svgEnumeration->setValueAsString(value);
     return svgEnumeration.release();
 }
 
 String SVGEnumerationBase::valueAsString() const
 {
     for (const auto& entry : m_entries) {
         if (m_value == entry.first)
             return entry.second;
     }
 
     ASSERT(m_value < maxInternalEnumValue());
     return emptyString();
 }
 
 void SVGEnumerationBase::setValue(unsigned short value)
 {
     m_value = value;
     notifyChange();
 }
 
-void SVGEnumerationBase::setValueAsString(const String& string, ExceptionState& exceptionState)
+SVGParsingError SVGEnumerationBase::setValueAsString(const String& string)
 {
     for (const auto& entry : m_entries) {
         if (string == entry.second) {
             // 0 corresponds to _UNKNOWN enumeration values, and should not be settable.
             ASSERT(entry.first);
             m_value = entry.first;
             notifyChange();
-            return;
+            return NoError;
         }
     }
 
-    exceptionState.throwDOMException(SyntaxError, "The value provided ('" + string + "') is invalid.");
     notifyChange();
+    return ParsingAttributeFailedError;
 }
 
 void SVGEnumerationBase::add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*)
 {
     ASSERT_NOT_REACHED();
 }
 
 void SVGEnumerationBase::calculateAnimatedValue(SVGAnimationElement* animationElement, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawPtr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*)
 {
     ASSERT(animationElement);
     unsigned short fromEnumeration = animationElement->animationMode() == ToAnimation ? m_value : toSVGEnumerationBase(from)->value();
     unsigned short toEnumeration = toSVGEnumerationBase(to)->value();
 
     animationElement->animateDiscreteType<unsigned short>(percentage, fromEnumeration, toEnumeration, m_value);
 }
 
 float SVGEnumerationBase::calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*)
 {
     // No paced animations for boolean.
     return -1;
 }
 
 }