Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: content/browser/download/download_item_impl.cc

Issue 1544653002: [Download] Treat RESUMING_INTERNAL as IN_PROGRESS in DownloadItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unify-downloader-core
Patch Set: Establishing dependency on other fixes. Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/download/download_item_impl_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // File method ordering: Methods in this file are in the same order as 5 // File method ordering: Methods in this file are in the same order as
6 // in download_item_impl.h, with the following exception: The public 6 // in download_item_impl.h, with the following exception: The public
7 // interface Start is placed in chronological order with the other 7 // interface Start is placed in chronological order with the other
8 // (private) routines that together define a DownloadItem's state 8 // (private) routines that together define a DownloadItem's state
9 // transitions as the download progresses. See "Download progression 9 // transitions as the download progresses. See "Download progression
10 // cascade" later in this file. 10 // cascade" later in this file.
(...skipping 1709 matching lines...) Expand 10 before | Expand all | Expand 10 after
1720 return IN_PROGRESS; 1720 return IN_PROGRESS;
1721 case COMPLETING_INTERNAL: 1721 case COMPLETING_INTERNAL:
1722 return IN_PROGRESS; 1722 return IN_PROGRESS;
1723 case COMPLETE_INTERNAL: 1723 case COMPLETE_INTERNAL:
1724 return COMPLETE; 1724 return COMPLETE;
1725 case CANCELLED_INTERNAL: 1725 case CANCELLED_INTERNAL:
1726 return CANCELLED; 1726 return CANCELLED;
1727 case INTERRUPTED_INTERNAL: 1727 case INTERRUPTED_INTERNAL:
1728 return INTERRUPTED; 1728 return INTERRUPTED;
1729 case RESUMING_INTERNAL: 1729 case RESUMING_INTERNAL:
1730 return INTERRUPTED; 1730 return IN_PROGRESS;
1731 case MAX_DOWNLOAD_INTERNAL_STATE: 1731 case MAX_DOWNLOAD_INTERNAL_STATE:
1732 break; 1732 break;
1733 } 1733 }
1734 NOTREACHED(); 1734 NOTREACHED();
1735 return MAX_DOWNLOAD_STATE; 1735 return MAX_DOWNLOAD_STATE;
1736 } 1736 }
1737 1737
1738 // static 1738 // static
1739 DownloadItemImpl::DownloadInternalState 1739 DownloadItemImpl::DownloadInternalState
1740 DownloadItemImpl::ExternalToInternalState( 1740 DownloadItemImpl::ExternalToInternalState(
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
1787 case RESUME_MODE_USER_CONTINUE: 1787 case RESUME_MODE_USER_CONTINUE:
1788 return "USER_CONTINUE"; 1788 return "USER_CONTINUE";
1789 case RESUME_MODE_USER_RESTART: 1789 case RESUME_MODE_USER_RESTART:
1790 return "USER_RESTART"; 1790 return "USER_RESTART";
1791 } 1791 }
1792 NOTREACHED() << "Unknown resume mode " << mode; 1792 NOTREACHED() << "Unknown resume mode " << mode;
1793 return "unknown"; 1793 return "unknown";
1794 } 1794 }
1795 1795
1796 } // namespace content 1796 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/download/download_item_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698