Submit buffered data use reports when Chromium is backgrounded

Submit buffered data use reports when Chromium is backgrounded

Currently, ExternalDataUseObserver buffers data use reports until the
sum of bytes across all reports exceeds |kDefaultDataUseReportMinBytes|.
This leads to loss of buffered reports, when Chromium is closed. By
reporting the bytes whenever Chromium goes into the background we can
reduce the unreported bytes.

BUG=570001
Committed: https://crrev.com/3ea246d66fe9bcab77d2c3ecc77331cf1ffb3fc5
Cr-Commit-Position: refs/heads/master@{#367126}

[Raj, 2015-12-21 20:33:04]

rajendrant@chromium.org changed reviewers:
+ tbansal@chromium.org

[Raj, 2015-12-21 20:33:04]

ptal, thanks

[tbansal1, 2015-12-21 21:03:25]

Please add tests:
(1) Report is submitted when the callback is called, even if the number of bytes
is less than the threshold
(2) Report is not submitted if there is a pending report.

https://codereview.chromium.org/1544633002/diff/1/chrome/browser/android/data...
File chrome/browser/android/data_usage/external_data_use_observer.cc (right):

https://codereview.chromium.org/1544633002/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.cc:217:
base::android::ApplicationState new_state) {
DCHECK(thread_checker...);

https://codereview.chromium.org/1544633002/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.cc:218: if
(new_state == base::android::APPLICATION_STATE_HAS_PAUSED_ACTIVITIES) {
braces not required.

https://codereview.chromium.org/1544633002/diff/1/chrome/browser/android/data...
File chrome/browser/android/data_usage/external_data_use_observer.h (right):

https://codereview.chromium.org/1544633002/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.h:87: void
OnApplicationStateChange(base::android::ApplicationState new_state);
Does this method need to be public?

[Raj, 2015-12-29 23:17:35]

ptal

https://codereview.chromium.org/1544633002/diff/1/chrome/browser/android/data...
File chrome/browser/android/data_usage/external_data_use_observer.cc (right):

https://codereview.chromium.org/1544633002/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.cc:217:
base::android::ApplicationState new_state) {
On 2015/12/21 21:03:24, tbansal1 wrote:
> DCHECK(thread_checker...);

Done.

https://codereview.chromium.org/1544633002/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.cc:218: if
(new_state == base::android::APPLICATION_STATE_HAS_PAUSED_ACTIVITIES) {
On 2015/12/21 21:03:24, tbansal1 wrote:
> braces not required.

Done.

https://codereview.chromium.org/1544633002/diff/1/chrome/browser/android/data...
File chrome/browser/android/data_usage/external_data_use_observer.h (right):

https://codereview.chromium.org/1544633002/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.h:87: void
OnApplicationStateChange(base::android::ApplicationState new_state);
On 2015/12/21 21:03:24, tbansal1 wrote:
> Does this method need to be public?

Done.

[tbansal1, 2015-12-30 00:12:05]

lgtm % nits.

https://chromiumcodereview.appspot.com/1544633002/diff/20001/chrome/browser/a...
File chrome/browser/android/data_usage/external_data_use_observer.h (right):

https://chromiumcodereview.appspot.com/1544633002/diff/20001/chrome/browser/a...
chrome/browser/android/data_usage/external_data_use_observer.h:209: // and vice
versa.
s/and/or?

https://chromiumcodereview.appspot.com/1544633002/diff/20001/chrome/browser/a...
chrome/browser/android/data_usage/external_data_use_observer.h:263: //
ApplicationStatusListener used to listen when Chromium gets backgrounded
Listens to when Chromium gets backgrounded and submits buffered data use
reports.

https://chromiumcodereview.appspot.com/1544633002/diff/20001/chrome/browser/a...
File chrome/browser/android/data_usage/external_data_use_observer_unittest.cc
(right):

https://chromiumcodereview.appspot.com/1544633002/diff/20001/chrome/browser/a...
chrome/browser/android/data_usage/external_data_use_observer_unittest.cc:498:
#endif
#endif  // OS_ANDROID

[Raj, 2015-12-30 01:41:42]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2015-12-30 01:41:42]

The patchset sent to the CQ was uploaded after l-g-t-m from tbansal@chromium.org
Link to the patchset: https://codereview.chromium.org/1544633002/#ps40001
(title: "Addressed nits")

[commit-bot: I haz the power, 2015-12-30 01:42:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1544633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1544633002/40001

[commit-bot: I haz the power, 2015-12-30 01:48:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-30 01:49:53]

Description was changed from

==========
Submit buffered data use reports when Chromium is backgrounded

Currently, ExternalDataUseObserver buffers data use reports until the
sum of bytes across all reports exceeds |kDefaultDataUseReportMinBytes|.
This leads to loss of buffered reports, when Chromium is closed. By
reporting the bytes whenever Chromium goes into the background we can
reduce the unreported bytes.

BUG=570001
==========

to

==========
Submit buffered data use reports when Chromium is backgrounded

Currently, ExternalDataUseObserver buffers data use reports until the
sum of bytes across all reports exceeds |kDefaultDataUseReportMinBytes|.
This leads to loss of buffered reports, when Chromium is closed. By
reporting the bytes whenever Chromium goes into the background we can
reduce the unreported bytes.

BUG=570001

Committed: https://crrev.com/3ea246d66fe9bcab77d2c3ecc77331cf1ffb3fc5
Cr-Commit-Position: refs/heads/master@{#367126}
==========

[commit-bot: I haz the power, 2015-12-30 01:49:54]

Patchset 3 (id:??) landed as
https://crrev.com/3ea246d66fe9bcab77d2c3ecc77331cf1ffb3fc5
Cr-Commit-Position: refs/heads/master@{#367126}