Hook up redirects for component builds

Hook up redirects for component builds

BUG=334379
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251823

[Cait (Slow), 2014-02-05 22:39:52]

Robert -- PTAL, this is the component build hookup for chrome_redirects, which
should be safe to land once my blink fix gets picked up by chrome.

[robertshield, 2014-02-06 01:39:29]

https://codereview.chromium.org/154463002/diff/1/chrome_elf/chrome_elf.gyp
File chrome_elf/chrome_elf.gyp (right):

https://codereview.chromium.org/154463002/diff/1/chrome_elf/chrome_elf.gyp#ne...
chrome_elf/chrome_elf.gyp:73: # default. Remove it here to avoid a circular
dependency.
Is the circular dependency really the reason for removing chrome_redirects from
the test targets?

https://codereview.chromium.org/154463002/diff/1/chrome_elf/chrome_elf.gyp#ne...
chrome_elf/chrome_elf.gyp:81: # A dummy target to ensure that chrome_elf.dll and
chrome.exe gets build
nit: build->built

[Cait (Slow), 2014-02-07 17:37:52]

https://codereview.chromium.org/154463002/diff/1/chrome_elf/chrome_elf.gyp
File chrome_elf/chrome_elf.gyp (right):

https://codereview.chromium.org/154463002/diff/1/chrome_elf/chrome_elf.gyp#ne...
chrome_elf/chrome_elf.gyp:73: # default. Remove it here to avoid a circular
dependency.
On 2014/02/06 01:39:29, robertshield wrote:
> Is the circular dependency really the reason for removing chrome_redirects
from
> the test targets?

Done.

https://codereview.chromium.org/154463002/diff/1/chrome_elf/chrome_elf.gyp#ne...
chrome_elf/chrome_elf.gyp:81: # A dummy target to ensure that chrome_elf.dll and
chrome.exe gets build
On 2014/02/06 01:39:29, robertshield wrote:
> nit: build->built

Done.

[robertshield, 2014-02-07 21:20:58]

lgtm

[Cait (Slow), 2014-02-18 16:15:11]

The CQ bit was checked by caitkp@chromium.org

[commit-bot: I haz the power, 2014-02-18 16:15:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/154463002/60001

[Cait (Slow), 2014-02-18 16:15:45]

The CQ bit was unchecked by caitkp@chromium.org

[Cait (Slow), 2014-02-18 16:15:46]

The CQ bit was checked by caitkp@chromium.org

[Cait (Slow), 2014-02-18 16:15:47]

The CQ bit was unchecked by caitkp@chromium.org

[Cait (Slow), 2014-02-18 17:42:33]

The CQ bit was checked by caitkp@chromium.org

[commit-bot: I haz the power, 2014-02-18 17:42:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/154463002/60001

[commit-bot: I haz the power, 2014-02-18 18:23:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/154463002/60001

[commit-bot: I haz the power, 2014-02-18 18:32:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/154463002/60001

[commit-bot: I haz the power, 2014-02-18 20:27:06]

Change committed as 251823