Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1544623002: Switch to standard integer types in printing/. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in printing/. BUG=138542 TBR=thestig@chromium.org Committed: https://crrev.com/126e93cfd2b197f92e3a0522a54072ece86287c7 Cr-Commit-Position: refs/heads/master@{#366463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -26 lines) Patch
M printing/backend/cups_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/backend/print_backend_dummy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/backend/print_backend_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/backend/printing_info_win.h View 4 chunks +5 lines, -4 lines 0 comments Download
M printing/backend/printing_info_win.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M printing/backend/win_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/backend/win_helper.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M printing/emf_win.h View 1 chunk +3 lines, -1 line 0 comments Download
M printing/emf_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M printing/emf_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/image.h View 1 chunk +3 lines, -1 line 0 comments Download
M printing/image.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/image_mac.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/image_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M printing/metafile.h View 1 chunk +3 lines, -1 line 0 comments Download
M printing/metafile.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/page_number.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/page_range.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/pdf_metafile_cg_mac.h View 1 chunk +2 lines, -1 line 0 comments Download
M printing/pdf_metafile_cg_mac.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/pdf_metafile_cg_mac_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/pdf_metafile_skia.h View 1 chunk +3 lines, -1 line 0 comments Download
M printing/pdf_metafile_skia.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M printing/print_settings_conversion.h View 1 chunk +0 lines, -1 line 0 comments Download
M printing/print_settings_conversion.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/print_settings_initializer_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/print_settings_initializer_mac.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/print_settings_initializer_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printed_document.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printed_page.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing_context.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing_context_android.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/printing_context_linux.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing_context_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing_context_no_system_dialog.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing_context_no_system_dialog.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing_context_system_dialog_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing_context_system_dialog_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing_context_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing_context_win_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M printing/printing_test.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/printing_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/printing_utils_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544623002/1
5 years ago (2015-12-21 20:24:27 UTC) #2
Lei Zhang
lgtm!
5 years ago (2015-12-21 21:22:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 21:48:23 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-21 21:49:31 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/126e93cfd2b197f92e3a0522a54072ece86287c7
Cr-Commit-Position: refs/heads/master@{#366463}

Powered by Google App Engine
This is Rietveld 408576698