Refactored InkDropAnimationControllerFactoryTests to use TEST_P and

Refactored InkDropAnimationControllerFactoryTests to use TEST_P and
INSTANTIATE_TEST_CASE_P.

The InkDropAnimationControllerFactoryTests were using a custom macro to
perform data driven testing.  This CL changes the tests to use the proper
GTest mechanism.

Committed: https://crrev.com/73247c876566f0c49f140cb5eb72f2d2d6c8d8b2
Cr-Commit-Position: refs/heads/master@{#367545}

[bruthig, 2015-12-21 19:53:35]

bruthig@chromium.org changed reviewers:
+ varkha@chromium.org

[bruthig, 2015-12-21 19:53:36]

varkha@, can you take a look before I send it off for an OWNERS review?

[varkha, 2015-12-22 02:49:57]

Not sure if I understand why it fails to apply the patch on the bots.

https://codereview.chromium.org/1544613002/diff/1/ui/views/animation/ink_drop...
File ui/views/animation/ink_drop_animation_controller_factory_unittest.cc
(right):

https://codereview.chromium.org/1544613002/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_animation_controller_factory_unittest.cc:6: #define
UI_VIEWS_ANIMATION_INK_DROP_ANIMATION_CONTROLLER_FACTORY_UNITTEST_H_
Is this necessary?

[bruthig, 2015-12-22 16:18:53]

Description was changed from

==========
Refactored InkDropAnimationControllerFactoryTests to use TEST_P and
INSTANTIATE_TEST_CASE_P.

The InkDropAnimationControllerFactoryTests were using a custom macro to
perform data driven testing.  This CL changes the tests to use the proper
GTest mechanism.
==========

to

==========
Refactored InkDropAnimationControllerFactoryTests to use TEST_P and
INSTANTIATE_TEST_CASE_P.

Based on CL here: https://codereview.chromium.org/1461673002

The InkDropAnimationControllerFactoryTests were using a custom macro to
perform data driven testing.  This CL changes the tests to use the proper
GTest mechanism.
==========

[bruthig, 2015-12-22 16:20:34]

I believe the try bot errors are because this CL is based off of
https://codereview.chromium.org/1461673002 which hasn't been submitted yet.

varkha@, PTAL.

https://codereview.chromium.org/1544613002/diff/1/ui/views/animation/ink_drop...
File ui/views/animation/ink_drop_animation_controller_factory_unittest.cc
(right):

https://codereview.chromium.org/1544613002/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_animation_controller_factory_unittest.cc:6: #define
UI_VIEWS_ANIMATION_INK_DROP_ANIMATION_CONTROLLER_FACTORY_UNITTEST_H_
On 2015/12/22 02:49:56, varkha wrote:
> Is this necessary?

Removed.

[bruthig, 2015-12-22 16:21:19]

Description was changed from

==========
Refactored InkDropAnimationControllerFactoryTests to use TEST_P and
INSTANTIATE_TEST_CASE_P.

Based on CL here: https://codereview.chromium.org/1461673002

The InkDropAnimationControllerFactoryTests were using a custom macro to
perform data driven testing.  This CL changes the tests to use the proper
GTest mechanism.
==========

to

==========
Refactored InkDropAnimationControllerFactoryTests to use TEST_P and
INSTANTIATE_TEST_CASE_P.

Based on CL here: https://codereview.chromium.org/1478303003

The InkDropAnimationControllerFactoryTests were using a custom macro to
perform data driven testing.  This CL changes the tests to use the proper
GTest mechanism.
==========

[bruthig, 2015-12-22 16:21:57]

On 2015/12/22 16:20:34, bruthig wrote:
> I believe the try bot errors are because this CL is based off of
> https://codereview.chromium.org/1461673002 which hasn't been submitted yet.
> 
> varkha@, PTAL.
> 
>
https://codereview.chromium.org/1544613002/diff/1/ui/views/animation/ink_drop...
> File ui/views/animation/ink_drop_animation_controller_factory_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/1544613002/diff/1/ui/views/animation/ink_drop...
> ui/views/animation/ink_drop_animation_controller_factory_unittest.cc:6:
#define
> UI_VIEWS_ANIMATION_INK_DROP_ANIMATION_CONTROLLER_FACTORY_UNITTEST_H_
> On 2015/12/22 02:49:56, varkha wrote:
> > Is this necessary?
> 
> Removed.

My bad, I said the wrong review in my comment.  It is based off of the CL here:
https://codereview.chromium.org/1478303003

[bruthig, 2015-12-23 19:49:53]

Description was changed from

==========
Refactored InkDropAnimationControllerFactoryTests to use TEST_P and
INSTANTIATE_TEST_CASE_P.

Based on CL here: https://codereview.chromium.org/1478303003

The InkDropAnimationControllerFactoryTests were using a custom macro to
perform data driven testing.  This CL changes the tests to use the proper
GTest mechanism.
==========

to

==========
Refactored InkDropAnimationControllerFactoryTests to use TEST_P and
INSTANTIATE_TEST_CASE_P.

The InkDropAnimationControllerFactoryTests were using a custom macro to
perform data driven testing.  This CL changes the tests to use the proper
GTest mechanism.
==========

[varkha, 2016-01-05 15:21:10]

lgtm

[bruthig, 2016-01-05 15:30:19]

bruthig@chromium.org changed reviewers:
+ sadrul@chromium.org

[bruthig, 2016-01-05 15:30:19]

sadrul@ can you PTAL?

[sadrul, 2016-01-05 16:01:49]

rs lgtm

[bruthig, 2016-01-05 16:03:17]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2016-01-05 16:04:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1544613002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1544613002/80001

[commit-bot: I haz the power, 2016-01-05 16:24:21]

Description was changed from

==========
Refactored InkDropAnimationControllerFactoryTests to use TEST_P and
INSTANTIATE_TEST_CASE_P.

The InkDropAnimationControllerFactoryTests were using a custom macro to
perform data driven testing.  This CL changes the tests to use the proper
GTest mechanism.
==========

to

==========
Refactored InkDropAnimationControllerFactoryTests to use TEST_P and
INSTANTIATE_TEST_CASE_P.

The InkDropAnimationControllerFactoryTests were using a custom macro to
perform data driven testing.  This CL changes the tests to use the proper
GTest mechanism.
==========

[commit-bot: I haz the power, 2016-01-05 16:24:21]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-05 16:25:19]

Description was changed from

==========
Refactored InkDropAnimationControllerFactoryTests to use TEST_P and
INSTANTIATE_TEST_CASE_P.

The InkDropAnimationControllerFactoryTests were using a custom macro to
perform data driven testing.  This CL changes the tests to use the proper
GTest mechanism.
==========

to

==========
Refactored InkDropAnimationControllerFactoryTests to use TEST_P and
INSTANTIATE_TEST_CASE_P.

The InkDropAnimationControllerFactoryTests were using a custom macro to
perform data driven testing.  This CL changes the tests to use the proper
GTest mechanism.

Committed: https://crrev.com/73247c876566f0c49f140cb5eb72f2d2d6c8d8b2
Cr-Commit-Position: refs/heads/master@{#367545}
==========

[commit-bot: I haz the power, 2016-01-05 16:25:20]

Patchset 5 (id:??) landed as
https://crrev.com/73247c876566f0c49f140cb5eb72f2d2d6c8d8b2
Cr-Commit-Position: refs/heads/master@{#367545}