content/browser/download/download_interrupt_reasons_impl.cc - Issue 1544603003: [Downloads] Do not store error responses during resumption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_interrupt_reasons_impl.cc

Issue 1544603003: [Downloads] Do not store error responses during resumption. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unify-downloader-core

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « content/browser/download/download_browsertest.cc ('k') | content/browser/download/download_item_impl.cc » ('j') | content/browser/download/download_item_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_interrupt_reasons_impl.cc

diff --git a/content/browser/download/download_interrupt_reasons_impl.cc b/content/browser/download/download_interrupt_reasons_impl.cc

index 2ed8f147ee05767c640fa8b1faa3be96041eb006..d9792d161f8b939b980014bcf81cff2c0e7a278c 100644

--- a/content/browser/download/download_interrupt_reasons_impl.cc

+++ b/content/browser/download/download_interrupt_reasons_impl.cc

@@ -84,6 +84,7 @@ DownloadInterruptReason ConvertNetErrorToInterruptReason(

return DOWNLOAD_INTERRUPT_REASON_NETWORK_TIMEOUT;

// The network connection has been lost.

+ case net::ERR_NETWORK_CHANGED:

svaldez 2016/01/13 17:29:18 Might want to split this out to a separate CL if t

asanka 2016/01/28 02:24:17 Makes sense. Done.

case net::ERR_INTERNET_DISCONNECTED:

return DOWNLOAD_INTERRUPT_REASON_NETWORK_DISCONNECTED;