[Downloads] Do not store error responses during resumption.

content/browser/download/download_request_core.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_REQUEST_CORE_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_REQUEST_CORE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <string>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "content/browser/loader/resource_handler.h"
 #include "content/public/browser/download_interrupt_reasons.h"
 #include "content/public/browser/download_save_info.h"
 #include "content/public/browser/download_url_parameters.h"
 
 namespace net {
+class HttpResponseHeaders;
 class URLRequest;
+class URLRequestStatus;
 }  // namespace net
 
 namespace content {
 class DownloadManagerImpl;
 class ByteStreamReader;
 class ByteStreamWriter;
 class PowerSaveBlocker;
 struct DownloadCreateInfo;
 
 // This class encapsulates the core logic for reading data from a URLRequest and
@@ skipping 18 matching lines @@
                       scoped_ptr<DownloadSaveInfo> save_info,
                       const base::Closure& on_ready_to_read_callback);
   ~DownloadRequestCore();
 
   // Should be called when the URLRequest::Delegate receives OnResponseStarted.
   // Constructs a DownloadCreateInfo and a ByteStreamReader that should be
   // passed into DownloadManagerImpl::StartDownload().
   //
   // Only populates the response derived fields of DownloadCreateInfo, with the
   // exception of |save_info|.
-  void OnResponseStarted(scoped_ptr<DownloadCreateInfo>* info,
-                         scoped_ptr<ByteStreamReader>* stream_reader);
+  //
+  // If the return value is not DOWNLOAD_INTERRUPT_REASON_NONE, then |info| and
+  // |stream_reader| will remain unchanged. In this case, the request isn't
+  // expected to continue.
+  DownloadInterruptReason OnResponseStarted(
+      scoped_ptr<DownloadCreateInfo>* info,
+      scoped_ptr<ByteStreamReader>* stream_reader) WARN_UNUSED_RESULT;
+
+  // Should be called to handle a redirect. The caller should only allow the
+  // redirect to be followed if the returned interrupt reason is NONE.
+  DownloadInterruptReason OnRequestRedirected(
+      const net::RedirectInfo& redirect_info);
 
   // Starts a read cycle. Creates a new IOBuffer which can be passed into
   // URLRequest::Read(). Call OnReadCompleted() when the Read operation
   // completes.
   bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
                   int* buf_size,
                   int min_size);
 
   // Should be called when the Read() operation completes. |defer| will be set
   // to true if reading is to be suspended. In the latter case, once more data
@@ skipping 21 matching lines @@
   // DownloadRequestCore will invoke the |on_ready_to_read_callback| to signal
   // to the caller that the read cycles should commence.
   void ResumeRequest();
 
   std::string DebugString() const;
 
  protected:
   net::URLRequest* request() const { return request_; }
 
  private:
+  static DownloadInterruptReason HandleRequestStatus(
+      const net::URLRequestStatus& status);
+
+  static DownloadInterruptReason HandleSuccessfulServerResponse(
+      const net::HttpResponseHeaders& http_headers,
+      DownloadSaveInfo* save_info);
+
   base::Closure on_ready_to_read_callback_;
   net::URLRequest* request_;
   scoped_ptr<DownloadSaveInfo> save_info_;
 
   // Data flow
   scoped_refptr<net::IOBuffer> read_buffer_;    // From URLRequest.
   scoped_ptr<ByteStreamWriter> stream_writer_;  // To rest of system.
 
   // Keeps the system from sleeping while this is alive. If the
   // system enters power saving mode while a request is alive, it can cause the
   // request to fail and the associated download will be interrupted.
   scoped_ptr<PowerSaveBlocker> power_save_blocker_;
 
   // The following are used to collect stats.
   base::TimeTicks download_start_time_;
   base::TimeTicks last_read_time_;
   base::TimeTicks last_stream_pause_time_;
   base::TimeDelta total_pause_time_;
   size_t last_buffer_size_;
   int64_t bytes_read_;
 
   int pause_count_;
   bool was_deferred_;
+  bool is_resumption_request_;
 
   // Each successful OnWillRead will yield a buffer of this size.
   static const int kReadBufSize = 32768;   // bytes
 
   DISALLOW_COPY_AND_ASSIGN(DownloadRequestCore);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_REQUEST_CORE_H_