[Downloads] Do not store error responses during resumption.

content/browser/download/download_request_core.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_REQUEST_CORE_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_REQUEST_CORE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 42 matching lines @@
   // DownloadRequestCore.
   DownloadRequestCore(net::URLRequest* request, Delegate* delegate);
   ~DownloadRequestCore();
 
   // Should be called when the URLRequest::Delegate receives OnResponseStarted.
   // Invokes Delegate::OnStart() with download start parameters. The
   // |override_mime_type| is used as the MIME type for the download when
   // constructing a DownloadCreateInfo object.
   bool OnResponseStarted(const std::string& override_mime_type);
 
+  // Should be called to handle a redirect. The caller should only allow the
+  // redirect to be followed if the return value is true.
+  bool OnRequestRedirected();
+
   // Starts a read cycle. Creates a new IOBuffer which can be passed into
   // URLRequest::Read(). Call OnReadCompleted() when the Read operation
   // completes.
   bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
                   int* buf_size,
                   int min_size);
 
+  // Used to notify DownloadRequestCore that the caller is about to abort the
+  // outer request. |reason| will be used as the final interrupt reason when
+  // OnResponseCompleted() is called.
+  void OnWillAbort(DownloadInterruptReason reason);
+
   // Should be called when the Read() operation completes. |defer| will be set
   // to true if reading is to be suspended. In the latter case, once more data
   // can be read, invokes the |on_ready_to_read_callback|.
   bool OnReadCompleted(int bytes_read, bool* defer);
 
   // Called to signal that the response is complete.
   //
   // It is expected that once this method is invoked, the DownloadRequestCore
   // object will be destroyed in short order without invoking any other methods
   // other than the destructor.
@@ skipping 56 matching lines @@
   // The following are used to collect stats.
   base::TimeTicks download_start_time_;
   base::TimeTicks last_read_time_;
   base::TimeTicks last_stream_pause_time_;
   base::TimeDelta total_pause_time_;
   size_t last_buffer_size_;
   int64_t bytes_read_;
 
   int pause_count_;
   bool was_deferred_;
-  bool is_resumption_request_;
+  bool is_partial_request_;
   bool started_;
 
   // When DownloadRequestCore initiates an abort (by blocking a redirect, for
   // example) it expects to eventually receive a OnResponseCompleted() with a
   // status indicating that the request was aborted. When this happens, the
   // interrupt reason in |abort_reason_| will be used instead of USER_CANCELED
   // which is vague.
   DownloadInterruptReason abort_reason_;
 
   // Each successful OnWillRead will yield a buffer of this size.
   static const int kReadBufSize = 32768;   // bytes
 
   DISALLOW_COPY_AND_ASSIGN(DownloadRequestCore);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_REQUEST_CORE_H_