Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: runtime/vm/compiler.cc

Issue 1544583002: For background compilation we copy ICData so that it is immutable during comnpilation. However, we … (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: l Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index a653a7db208686fc303e3de0abdcd8433a3abd6e..bdb577420a9f0b5cc250d518bbd5bf78c5bbd4f7 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -42,6 +42,7 @@ namespace dart {
DEFINE_FLAG(bool, allocation_sinking, true,
"Attempt to sink temporary allocations to side exits");
+DEFINE_FLAG(bool, always_clone_ic_descriptor, false, "Testing flag");
zra 2015/12/21 19:31:47 Did you mean to leave this in? If so, is it possib
srdjan 2015/12/21 20:22:49 Removing it, once all platforms pass.
DEFINE_FLAG(bool, common_subexpression_elimination, true,
"Do common subexpression elimination.");
DEFINE_FLAG(bool, constant_propagation, true,
@@ -461,7 +462,8 @@ static bool CompileParsedFunctionHelper(CompilationPipeline* pipeline,
// 'Freeze' ICData in background compilation so that it does not
// change while compiling.
- const bool clone_descriptors = Compiler::IsBackgroundCompilation();
+ const bool clone_descriptors = FLAG_always_clone_ic_descriptor ||
+ Compiler::IsBackgroundCompilation();
function.RestoreICDataMap(ic_data_array, clone_descriptors);
if (FLAG_print_ic_data_map) {

Powered by Google App Engine
This is Rietveld 408576698