For background compilation we copy ICData so that it is immutable during comnpilation. However, we …

For background compilation we copy ICData so that it is immutable during comnpilation. However, we must emit the original, shared ICData in the code. Provide a link from cloned ICData object to the original one.

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/ab7525a8201dba6bc0974f92fa0d39de98abb6d6

[srdjan, 2015-12-21 18:39:17]

srdjan@google.com changed reviewers:
+ zra@google.com

[zra, 2015-12-21 19:31:47]

https://codereview.chromium.org/1544583002/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1544583002/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:45: DEFINE_FLAG(bool, always_clone_ic_descriptor, false,
"Testing flag");
Did you mean to leave this in? If so, is it possible to include a bit more about
what the flag does?

https://codereview.chromium.org/1544583002/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1544583002/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:12205: void ICData::SetOriginal(const ICData& value) const
{
It looks like there is an assumption that the original pointed to by the owner_
field is not a copy. Would this be the right place to assert that?

https://codereview.chromium.org/1544583002/diff/20001/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/1544583002/diff/20001/runtime/vm/raw_object.h...
runtime/vm/raw_object.h:1406: RawString* target_name_;     // Name of target
function.
Maybe un-align the rest of these as well.

[srdjan, 2015-12-21 20:22:49]

PTAL

https://codereview.chromium.org/1544583002/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1544583002/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:45: DEFINE_FLAG(bool, always_clone_ic_descriptor, false,
"Testing flag");
On 2015/12/21 19:31:47, zra wrote:
> Did you mean to leave this in? If so, is it possible to include a bit more
about
> what the flag does?

Removing it, once all platforms pass.

https://codereview.chromium.org/1544583002/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1544583002/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:12205: void ICData::SetOriginal(const ICData& value) const
{
On 2015/12/21 19:31:47, zra wrote:
> It looks like there is an assumption that the original pointed to by the
owner_
> field is not a copy. Would this be the right place to assert that?

Done.

https://codereview.chromium.org/1544583002/diff/20001/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/1544583002/diff/20001/runtime/vm/raw_object.h...
runtime/vm/raw_object.h:1406: RawString* target_name_;     // Name of target
function.
On 2015/12/21 19:31:47, zra wrote:
> Maybe un-align the rest of these as well.

Done.

[zra, 2015-12-21 20:25:25]

lgtm

[srdjan, 2015-12-21 22:49:33]

Description was changed from

==========
For background compilation we copy ICData so that it is immutable during
comnpilation. However, we must emit the original, shared ICData in the code.
Provide a link from cloned ICData object to the original one.

BUG=
==========

to

==========
For background compilation we copy ICData so that it is immutable during
comnpilation. However, we must emit the original, shared ICData in the code.
Provide a link from cloned ICData object to the original one.

BUG=
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ab7525a8201dba6bc0974f92fa0d39de98abb6d6
==========

[srdjan, 2015-12-21 22:49:34]

Committed patchset #5 (id:80001) manually as
ab7525a8201dba6bc0974f92fa0d39de98abb6d6 (presubmit successful).