Issue 1544563002: Adds a DCHECK that the host argument to QuicInMemoryCache::AddResponse is not empty. An empty host …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1544563002: Adds a DCHECK that the host argument to QuicInMemoryCache::AddResponse is not empty. An empty host … (Closed)

Created:
5 years ago by Fan Yang

Modified:
4 years, 11 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@110267778

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Adds a DCHECK that the host argument to QuicInMemoryCache::AddResponse is not empty. An empty host works fine in google3, but breaks tests in Chromium for $reasons. n/a (QUIC test only) Merge internal change: 110286048 R=rch@chromium.org

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -10 lines)			Patch
M	net/tools/quic/quic_in_memory_cache.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/tools/quic/quic_simple_server_stream_test.cc	View	7 chunks	+10 lines, -10 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_client.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Dependent Patchsets:

Issue 1543703002 Patch 10008

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages